Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gatsby-plugin-typography breaks site in IE11? #5553

Closed
jp887 opened this issue May 25, 2018 · 14 comments
Closed

gatsby-plugin-typography breaks site in IE11? #5553

jp887 opened this issue May 25, 2018 · 14 comments
Labels
stale? Issue that may be closed soon due to the original author not responding any more. status: awaiting author response Additional information has been requested from the author type: bug An issue or pull request relating to a bug in Gatsby

Comments

@jp887
Copy link

jp887 commented May 25, 2018

The default Gatsby starter works great in IE11. However, after installing gatsby-plugin-typography I get the following error in the browser console and the app fails:

Object doesn't support property or method 'assign'

The same error occurs for starters that use typography.js by default like the blog starter.

I even get this error in the console when I visit the Gatsby documentation site (which presumably uses typography.js).

I've tried adding babel-polyfill using this method but this didn't seem to make a difference. In any case, as far as I can tell the babel-preset-env config is including a polyfill for Object.assign anyway.

The Object.assign statement that is failing seems be within typography.js code that gets included in the production bundle. I was actually slightly surprised to find typography.js code is running on the client for production builds, as I though typography.js was just used to generate styles to be added to the document head at build time?

In any case I need to support IE11 in my site. Any advice would be much appreciated.

@jp887 jp887 changed the title gatsby-plugin-typography breaks app in IE11? gatsby-plugin-typography breaks site in IE11? May 25, 2018
@pieh pieh added the type: bug An issue or pull request relating to a bug in Gatsby label May 30, 2018
@pieh
Copy link
Contributor

pieh commented May 30, 2018

I can confirm - it happens on gatsbyjs.org too in IE11

@KyleAMathews should typograhy code be included in production runtime? (not familiar with it)

@KyleAMathews
Copy link
Contributor

Typography.js can also be used in the browser to style components using css-in-js. I have a refactor almost ready that'll remove this particular error.

@jp887
Copy link
Author

jp887 commented May 30, 2018

Thanks @KyleAMathews. Out of interest what's the need to do typography styling via css-in-js in Gatsby if the css is already injected into the document head?

@KyleAMathews
Copy link
Contributor

Stuff like paddings/margins or setting custom font sizes.

@jp887
Copy link
Author

jp887 commented Jun 18, 2018

@KyleAMathews any idea when this fix will be ready? I have a site going live soon that needs to support IE11. If the fix is a still a while off I'll temporarily remove typography.js. Thanks again.

@dectys
Copy link

dectys commented Sep 27, 2018

Same problem here with IE11, is that soon to be released or is there a quick fix ? Thanks

@gatsbot gatsbot bot added the stale? Issue that may be closed soon due to the original author not responding any more. label Jan 16, 2019
@gatsbot
Copy link

gatsbot bot commented Jan 16, 2019

Old issues will be closed after 30 days of inactivity. This issue has been quiet for 20 days and is being marked as stale. Reply here or add the label "not stale" to keep this issue open!

@mclarkos
Copy link

Not stale—still keen to see this fixed.

@gatsbot
Copy link

gatsbot bot commented Jan 27, 2019

This issue is being closed due to inactivity. Is this a mistake? Please re-open this issue or create a new issue.

@gatsbot gatsbot bot closed this as completed Jan 27, 2019
@TuckerWhitehouse
Copy link
Contributor

This is is not stale and should be re-opened.

@KyleAMathews KyleAMathews reopened this Jan 27, 2019
@pieh pieh removed the stale? Issue that may be closed soon due to the original author not responding any more. label Jan 27, 2019
@gatsbot
Copy link

gatsbot bot commented Feb 18, 2019

Hiya!

This issue has gone quiet. Spooky quiet. 👻

We get a lot of issues, so we currently close issues after 30 days of inactivity. It’s been at least 20 days since the last update here.

If we missed this issue or if you want to keep it open, please reply here. You can also add the label "not stale" to keep this issue open!

Thanks for being a part of the Gatsby community! 💪💜

@gatsbot gatsbot bot added the stale? Issue that may be closed soon due to the original author not responding any more. label Feb 18, 2019
@TuckerWhitehouse TuckerWhitehouse added not stale and removed stale? Issue that may be closed soon due to the original author not responding any more. labels Feb 18, 2019
@wardpeet
Copy link
Contributor

@TuckerWhitehouse still an issue? I couldn't reproduce it. I just followed https://www.gatsbyjs.org/docs/typography-js/

@wardpeet wardpeet added status: awaiting author response Additional information has been requested from the author and removed not stale labels Jun 14, 2019
@gatsbot
Copy link

gatsbot bot commented Jul 5, 2019

Hiya!

This issue has gone quiet. Spooky quiet. 👻

We get a lot of issues, so we currently close issues after 30 days of inactivity. It’s been at least 20 days since the last update here.

If we missed this issue or if you want to keep it open, please reply here. You can also add the label "not stale" to keep this issue open!

As a friendly reminder: the best way to see this issue, or any other, fixed is to open a Pull Request. Check out gatsby.dev/contributefor more information about opening PRs, triaging issues, and contributing!

Thanks for being a part of the Gatsby community! 💪💜

@gatsbot gatsbot bot added the stale? Issue that may be closed soon due to the original author not responding any more. label Jul 5, 2019
@gatsbot
Copy link

gatsbot bot commented Jul 16, 2019

Hey again!

It’s been 30 days since anything happened on this issue, so our friendly neighborhood robot (that’s me!) is going to close it.

Please keep in mind that I’m only a robot, so if I’ve closed this issue in error, I’m HUMAN_EMOTION_SORRY. Please feel free to reopen this issue or create a new one if you need anything else.

As a friendly reminder: the best way to see this issue, or any other, fixed is to open a Pull Request. Check out gatsby.dev/contribute for more information about opening PRs, triaging issues, and contributing!

Thanks again for being part of the Gatsby community!

@gatsbot gatsbot bot closed this as completed Jul 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale? Issue that may be closed soon due to the original author not responding any more. status: awaiting author response Additional information has been requested from the author type: bug An issue or pull request relating to a bug in Gatsby
Projects
None yet
Development

No branches or pull requests

7 participants