Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v2] Fix tests and linting #5131

Closed
m-allanson opened this issue Apr 25, 2018 · 3 comments
Closed

[v2] Fix tests and linting #5131

m-allanson opened this issue Apr 25, 2018 · 3 comments
Assignees
@m-allanson
Labels
type: maintenance An issue or pull request describing a change that isn't a bug, feature or documentation change

Comments

@m-allanson
Copy link
Contributor

Update the tests to work with v2
@m-allanson
Copy link
Contributor Author

m-allanson commented Apr 25, 2018 •
edited
Loading

Related PRs:

@m-allanson m-allanson self-assigned this Apr 25, 2018
@m-allanson m-allanson added the type: maintenance An issue or pull request describing a change that isn't a bug, feature or documentation change label Apr 26, 2018
@m-allanson m-allanson mentioned this issue Apr 30, 2018
Merged
@m-allanson
Copy link
Contributor Author

m-allanson commented May 10, 2018 •
edited
Loading

This is currently blocked by #5354, which causes the UI tests to fail.

Unblocked by #5356 as a temp workaround.

@m-allanson m-allanson added the status: blocked This issue/PR can't be solved at the moment and shouldn't be closed/merged label May 10, 2018
@m-allanson m-allanson mentioned this issue May 10, 2018
Closed
@m-allanson m-allanson removed the status: blocked This issue/PR can't be solved at the moment and shouldn't be closed/merged label May 10, 2018
@m-allanson m-allanson mentioned this issue May 10, 2018
Merged
@m-allanson
Copy link
Contributor Author

m-allanson commented May 16, 2018 •
edited
Loading

Done in the PRs referenced above. Thanks everyone that worked on these 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@m-allanson m-allanson

Labels
type: maintenance An issue or pull request describing a change that isn't a bug, feature or documentation change
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@m-allanson