-
Notifications
You must be signed in to change notification settings - Fork 10.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Maintain light purple selected state in plugin library #4670
Comments
@fk we had styles for this right? |
@shannonbux sounds like what you are saying is a Current state needs to be shown on the plugins list. Currently, there is a Hover state, but no Active/Current indicator. Here's a simple concept to consider if these styles don't already exist: |
So we have the styles for selected state of a search result card but the logic to check if a result is selected is broken. Before I push a fix for this, is the existing style for the selected plugin enough? Or should I change the style as described above? This is how it looks with the current styles: |
Yeah, the current styles are fine — let's get it restored first and if we think the styles should be changed, let's do that in a follow-up PR. |
Looks like this is done! Will close and thanks everyone!!! |
Sorry @KyleAMathews, only saw your comment now :-/ (thanks to @shannonbux' last comment from today and Gmail filters finally set up 🎉). Not opposed to make the current "selected" state clearer, and I also like the hover-state @calebsylvest suggested – seems a bit lighter than the current ones, while still visible enough? Thanks @tsriram! 🤗<3 |
Problem
I observed someone using the plugin library yesterday, and noticed that this workflow has a painpoint for him:
Solution
When someone clicks a plugin card on the left, if the light purple selected state persisted until they click on another plugin card, they wouldn't have the problem described above.
The text was updated successfully, but these errors were encountered: