Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gatsby Image importing createRoot from react-dom instead of react-dom/client #35095

Closed
2 tasks done
mwskwong opened this issue Mar 10, 2022 · 0 comments · Fixed by #35108
Closed
2 tasks done

Gatsby Image importing createRoot from react-dom instead of react-dom/client #35095

mwskwong opened this issue Mar 10, 2022 · 0 comments · Fixed by #35108
Labels
topic: media Related to gatsby-plugin-image, or general image/media processing topics type: bug An issue or pull request relating to a bug in Gatsby

Comments

@mwskwong
Copy link

Preliminary Checks

Description

Appears on React 18 RC 1 or later.
image

Reproduction Link

https://github.com/mwskwong/gatsby-image-react-rc-1

Steps to Reproduce

  1. Genearte a Gatsby site using any template
  2. Upgrade React to 18.0.0-rc.1 or later
  3. Use any components in gatsby-plugin-image

Expected Result

No error prompted

Actual Result

React complains createRoot is being imported from the wrong path.

Environment

System:
    OS: Windows 10 10.0.22000
    CPU: (8) x64 11th Gen Intel(R) Core(TM) i7-1165G7 @ 2.80GHz
  Binaries:
    Node: 16.13.2 - C:\Program Files\nodejs\node.EXE
    npm: 8.1.2 - C:\Program Files\nodejs\npm.CMD
  Languages:
    Python: 3.10.2
  Browsers:
    Edge: Spartan (44.22000.120.0), Chromium (99.0.1150.36)
  npmPackages:
    gatsby: ^4.9.3 => 4.9.3 
    gatsby-plugin-image: ^2.9.1 => 2.9.1 
    gatsby-plugin-sharp: ^4.9.1 => 4.9.1 
    gatsby-source-filesystem: ^4.9.1 => 4.9.1 
    gatsby-transformer-sharp: ^4.9.0 => 4.9.0

Config Flags

No response

@mwskwong mwskwong added the type: bug An issue or pull request relating to a bug in Gatsby label Mar 10, 2022
@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Mar 10, 2022
@LekoArts LekoArts added topic: media Related to gatsby-plugin-image, or general image/media processing topics and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Mar 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: media Related to gatsby-plugin-image, or general image/media processing topics type: bug An issue or pull request relating to a bug in Gatsby
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants