Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(gatsby-transformer-remark): ensure getNodesByType() is passed through #28218

Merged
merged 1 commit into from
Nov 23, 2020
Merged

fix(gatsby-transformer-remark): ensure getNodesByType() is passed through #28218

merged 1 commit into from
Nov 23, 2020

Conversation

hassankhan
Copy link
Contributor

@hassankhan hassankhan commented Nov 22, 2020 •
edited
Loading

Description

Add getNodesByType() to the other parameters so it is correctly passed through to Gatsby Remark plugins.

Documentation

https://www.gatsbyjs.com/tutorial/remark-plugin-tutorial/

Related Issues

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Nov 22, 2020
@hassankhan hassankhan mentioned this pull request Nov 22, 2020
Closed
4 tasks
@hassankhan
Copy link
Contributor Author

Not sure why the CI failed - possibly a Yarn PnP related issue?

@merceyz
Copy link
Contributor

merceyz commented Nov 23, 2020

Not sure why the CI failed - possibly a Yarn PnP related issue?

The PnP patch for typescript is out of date, we've updated it but haven't released it yet. Will be fixed in the next release of Yarn

@pieh pieh added topic: remark/mdx Related to Markdown, remark & MDX ecosystem and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Nov 23, 2020
@pieh pieh self-assigned this Nov 23, 2020
pieh
pieh approved these changes Nov 23, 2020
View reviewed changes
Copy link
Contributor

@pieh pieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, thanks for the fix @hassankhan

@pieh
Copy link
Contributor

pieh commented Nov 23, 2020 •
edited
Loading

I will not block this PR on PnP tests because this one doesn't change any dependencies or imports so it won't impact PnP.

@merceyz is there some way to subscribe / get notification when new version is released? We do have pinned yarn/berry version in our test setup -

gatsby/.circleci/config.yml

Line 322 in b346804

command: yarn set version 2.0.0-rc.32
- so we aren't always on latest (hence we wouldn't get that test "auto-fixed" at some point). It didn't cause issues since it was setup few months ago by Maël (in #23139) until recently ;)

We might want to revisit this setup because #28238 happened at some point that possible could have been prevented with different setup

@pieh pieh merged commit 7867897 into gatsbyjs:master Nov 23, 2020
@arcanis
Copy link
Contributor

arcanis commented Nov 23, 2020

If you remove these lines your tests will always run against the latest stable releases (because of this). For notifications we don't currently have a good way of being aware of them (apart following us on Twitter 😄), but I'll look into that for 3.x, as part of the release automation work I plan to do.

@hassankhan hassankhan deleted the hassankhan/fix/ensure-getnodesbytype-is-passed branch November 24, 2020 07:08
This was referenced Nov 24, 2020
Merged
Merged
vladar pushed a commit that referenced this pull request Nov 24, 2020
@hassankhan @vladar
fix(gatsby-transformer-remark): ensure getNodesByType() is passed t…
2c93825 
…hrough (#28218)

(cherry picked from commit 7867897)
vladar added a commit that referenced this pull request Nov 24, 2020
@vladar @hassankhan
fix(gatsby-transformer-remark): ensure getNodesByType() is passed t…
63e189d 
…hrough (#28218) (#28261)

(cherry picked from commit 7867897)

Co-authored-by: Hassan Khan <[email protected]>
@pieh pieh mentioned this pull request Nov 25, 2020
Merged
This was referenced Mar 15, 2021
Merged
Open
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pieh pieh pieh approved these changes

Assignees

@pieh pieh

Labels
topic: remark/mdx Related to Markdown, remark & MDX ecosystem
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hassankhan @merceyz @pieh @arcanis