Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hot reload broken since 2.24.0 #28202

Closed
tu4mo opened this issue Nov 20, 2020 · 1 comment
Closed

Hot reload broken since 2.24.0 #28202

tu4mo opened this issue Nov 20, 2020 · 1 comment
Labels
type: bug An issue or pull request relating to a bug in Gatsby

Comments

@tu4mo
Copy link

tu4mo commented Nov 20, 2020

Description

Hot reload fails to show changes in an outside library (imported in Gatsby pages).

Steps to reproduce

Make a change in outside library. I use a separate Yarn workspace for the library. Rollup for bundling. Gatsby detects the change (from what I can understand from the terminal) when library gets rebuild, but fails to show changes in browser.

I have a feeling like there is some race condition happening; parts of the library gets built, Gatsby notices the change and starts to rebuild pages, and during that time the rest of the library gets built (takes about 2 seconds) and Gatsby fails to notice that.

Expected result

Everything updates like in 2.24.0.

Actual result

Changes does not get updated in the browser. At some point the whole page hangs and I have to restart the server.

Environment

  System:
    OS: macOS 11.0.1
    CPU: (8) x64 Intel(R) Core(TM) i7-8559U CPU @ 2.70GHz
    Shell: 5.8 - /bin/zsh
  Binaries:
    Node: 14.15.1 - ~/.nvm/versions/node/v14.15.1/bin/node
    Yarn: 1.22.10 - /usr/local/bin/yarn
    npm: 6.14.8 - ~/.nvm/versions/node/v14.15.1/bin/npm
  Languages:
    Python: 2.7.16 - /usr/bin/python
  Browsers:
    Chrome: 87.0.4280.67
    Edge: 87.0.664.41
    Firefox: 82.0.3
    Safari: 14.0.1
@tu4mo tu4mo added the type: bug An issue or pull request relating to a bug in Gatsby label Nov 20, 2020
@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Nov 20, 2020
@vladar
Copy link
Contributor

vladar commented Nov 20, 2020

I think it is a duplicate of #27609 Let's keep tracking it there.

@vladar vladar closed this as completed Nov 20, 2020
@vladar vladar removed the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Nov 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug An issue or pull request relating to a bug in Gatsby
Projects
None yet
Development

No branches or pull requests

2 participants