fix(gatsby-plugin-manifest): Only reassign start_url if it already exists #21012
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, I'm seeing the following error coming from `gatsby-plugin-manifest` when I'm using only the `icon` option: ``` The "path" argument must be of type string. Received type undefined ``` This happens because the `start_url` option is undefined unless set by the user, yet we're passing it as an argument to `path.posix.join`, which expects each argument to be a string. This change adds a condition around the line reassigning `manifest.start_url` to make sure it exists first.
pieh
changed the title
pieh
approved these changes
Jan 29, 2020
pieh
added
the
bot: merge on green
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, I'm seeing the following error coming from
gatsby-plugin-manifestwhen I'm using only theiconoption:This happens because the
start_urloption is undefined unless set by the user, yet we're passing it as an argument topath.posix.join, which expects each argument to be a string. This change adds a condition around the line reassigningmanifest.start_urlto make sure it exists first.