Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize all docs/ images #18776

Closed
nucliweb opened this issue Oct 17, 2019 · 3 comments
Closed

Optimize all docs/ images #18776

nucliweb opened this issue Oct 17, 2019 · 3 comments

Comments

@nucliweb
Copy link

Summary

I know that the plugins optimize the images in the build process, but we can optimize lossless all images into the docs folder: screenshots, avatars, gif animations, etc...

This optimizes too the build time because the images are smaller

Basic example

I have the images optimized in perf/images-optimization, the commit include 672 images 😱

I used ImageOptim to optimize them.

ImageOptim

Ressult

This is the docs folder size:

Before
258.981.060 bytes (261,7 MB on disk) for 1.516 items

After
196.442.901 bytes (199,2 MB on disk) for 1.516 items

Motivation

I 💜 Image Optimization 🏞
And with this action, we can reduce 62 MB the repo size with the same images quality 😊

So...

If you agree, I will send a PR to start the revision process.

@horacioh horacioh assigned horacioh and unassigned horacioh Oct 17, 2019
@horacioh
Copy link
Contributor

horacioh commented Oct 17, 2019

ping @LekoArts @m-allanson @sidharthachatterjee :)
this would be great for the translation repos too 👍

@nucliweb
Copy link
Author

Although I would love to send a PR like this to the Gatsby's repo 😊.

I have been thinking of a better and more automated solution. I think it would be easier and will help future image optimizations implement ImgBot.

@LekoArts
Copy link
Contributor

LekoArts commented Nov 4, 2019

Hey, thanks for the issue. I'll mark this as a duplicate of #13699

Important note: Changing images without rewriting history (like mentioned in the linked issue) hugely increases the Git history.

@LekoArts LekoArts closed this as completed Nov 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants