Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] A doc on how to follow up with reviews after a PR #18102

Closed
urielhdz opened this issue Oct 4, 2019 · 2 comments
Closed

[docs] A doc on how to follow up with reviews after a PR #18102

urielhdz opened this issue Oct 4, 2019 · 2 comments
Labels
stale? Issue that may be closed soon due to the original author not responding any more. type: documentation An issue or pull request for improving or updating Gatsby's documentation

Comments

@urielhdz
Copy link
Contributor

urielhdz commented Oct 4, 2019

Summary

Create a guide to explain how to solve changes requests after a PR, these guide could be complementary to the How to Open a Pull Request guide that was published recently.

Motivation

After my first PR I received reviews from both the community and the core team and at first I didn't know how to address them, @marcysutton pointed out that GitHub allows you to resolve all reviews at once but the UI it is not very intuitive for beginners.

I would like for this guide to address questions such as. Do I resolve the suggestions directly on with the GitHub UI or through my local Gatsby setup? How to solve multiple suggestions at once using the GitHub UI, how to follow up with discussions, etc.

There's already a section on the How to Open a Pull Request guide on how to keep your fork updated, and I think this guide could either point out to that section or place that content in it.

If it's something you consider useful I could work on it.

@gatsbot gatsbot bot added the type: documentation An issue or pull request for improving or updating Gatsby's documentation label Oct 4, 2019
@marcysutton
Copy link
Contributor

Hey @urielhdz! That sounds like great information to include. I'd recommend putting it in the existing How To Open a PR doc rather than a separate one since it's the same workflow – you'd have to first open a PR to the information to be relevant. What do you think?

@gatsbot gatsbot bot added the stale? Issue that may be closed soon due to the original author not responding any more. label Oct 25, 2019
@gatsbot gatsbot bot closed this as completed Nov 5, 2019
@gatsbyjs gatsbyjs deleted a comment from gatsbot bot Nov 6, 2019
@gatsbyjs gatsbyjs deleted a comment from gatsbot bot Nov 6, 2019
@marcysutton
Copy link
Contributor

Closed with #18745. Thanks @urielhdz!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale? Issue that may be closed soon due to the original author not responding any more. type: documentation An issue or pull request for improving or updating Gatsby's documentation
Projects
None yet
Development

No branches or pull requests

2 participants