Skip to content

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] [workflows] Implementing Google Amp #17645

Closed
3 tasks
brolag opened this issue Sep 15, 2019 · 4 comments
Closed
3 tasks

[docs] [workflows] Implementing Google Amp #17645

brolag opened this issue Sep 15, 2019 · 4 comments
Labels
type: documentation An issue or pull request for improving or updating Gatsby's documentation

Comments

@brolag
Copy link

brolag commented Sep 15, 2019

Part of the Top 25 Learning Workflows initiative. See #13708 for the meta issue that this issue falls under.

User story

As a new Gatsby user, I want to implement Google AMP.

Evaluation

[Change emoji below based on your evaluation.]

Search Discover Complete Linked Tone Style Overall
😄 😞 😐 😄 😐 😐 😐

Steps taken to implement

  1. Searchability
    i. Searched gatsby implement google amp; clicked first result.

  2. Discoverability
    i. Searched google amp in search bar but didn't find the package link.

  3. Completness
    i. Followed steps in Gatsby Plugin Amp
    ii. Installed Gatsby Plugin Amp
    iii. Replaced Img component with amp-img
    vi. Success!
    Notes: no tall tags are completed and documented.

  4. Linked
    i. Link to general information about Google AMP.
    ii. Link to analytics types.
    iii. Available components link is broken.
    iv. Link for Google Analytics Client ID tutorial.

  5. Tone
    i. Very technical tone for options section and caveats section.

  6. Style.
    i. Minor issues only such as periods at ends.

  7. Overall
    i. Not all tags are completed however plugin documentation is very self explanatory, it requires previous AMP knowledge.

Recommendations

  • Provide examples for YouTube, Twitter and iframe, like it is described for amp-img.
  • Fix end of paragraph punctuation.
  • Try Google Analytics, YouTube and Twitter implementations.

Feel free to edit this issue with more results about other HTML tags.

@LekoArts LekoArts added the type: documentation An issue or pull request for improving or updating Gatsby's documentation label Sep 16, 2019
@gatsbot
Copy link

gatsbot bot commented Oct 7, 2019

Hiya!

This issue has gone quiet. Spooky quiet. 👻

We get a lot of issues, so we currently close issues after 30 days of inactivity. It’s been at least 20 days since the last update here.

If we missed this issue or if you want to keep it open, please reply here. You can also add the label "not stale" to keep this issue open!

As a friendly reminder: the best way to see this issue, or any other, fixed is to open a Pull Request. Check out gatsby.dev/contribute for more information about opening PRs, triaging issues, and contributing!

Thanks for being a part of the Gatsby community! 💪💜

@gatsbot gatsbot bot added the stale? Issue that may be closed soon due to the original author not responding any more. label Oct 7, 2019
@gatsbot
Copy link

gatsbot bot commented Oct 18, 2019

Hey again!

It’s been 30 days since anything happened on this issue, so our friendly neighborhood robot (that’s me!) is going to close it.

Please keep in mind that I’m only a robot, so if I’ve closed this issue in error, I’m HUMAN_EMOTION_SORRY. Please feel free to reopen this issue or create a new one if you need anything else.

As a friendly reminder: the best way to see this issue, or any other, fixed is to open a Pull Request. Check out gatsby.dev/contribute for more information about opening PRs, triaging issues, and contributing!

Thanks again for being part of the Gatsby community!

@gatsbot gatsbot bot closed this as completed Oct 18, 2019
@marcysutton
Copy link
Contributor

Reopening this as the workflow evaluation still needs to be implemented. Thanks so much for opening this issue!

@marcysutton marcysutton reopened this Apr 7, 2020
@marcysutton marcysutton added not stale and removed stale? Issue that may be closed soon due to the original author not responding any more. labels Apr 7, 2020
@joyfulelement
Copy link
Contributor

There had been discussions on #13454 about the proposed requirement, POC experiments and action items on how Gatsby could provide first-class support for Google AMP.

As much as myself also looking for information about how to support Google AMP with Gatsby, correct me if I am wrong, but base on what I understand on people's prior attempts with various plug-ins such as gatsby-plugin-amp mentioned by @brolag, gatsby-plugin-google-amp and gatsby-plugin-html2amp, there are still work to be done in Gatsby core or plug-ins in order to complete the support for Google AMP.

I believe this would continue block the recommended docs items until there is a clear path on how Gatsby decide to support Google AMP. Any idea if this is still on Gatsby's current roadmap @marcysutton? while AMP continue to evolve, which is also supported by Next a year ago. Thanks.

@LekoArts LekoArts closed this as completed May 4, 2021
@gatsbyjs gatsbyjs locked and limited conversation to collaborators May 4, 2021
@LekoArts LekoArts removed the not stale label May 7, 2021

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

Labels
type: documentation An issue or pull request for improving or updating Gatsby's documentation
Projects
None yet
Development

No branches or pull requests

4 participants