Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gatsby-transformer-remark): fix spaces between text-bearing block-level elements in plain text excerpts #15040

Merged

Conversation

mxxk
Copy link
Contributor

@mxxk mxxk commented Jun 22, 2019

Description

Fixes excerpt generation (in plain text mode) to add spaces between text-bearing block-level elements (i.e. paragraphs, headings, table cells) as well as line breaks.

That way, for the Markdown document

Paragraph 

# Heading

Broken  
Line

| TableCell |
| --------- |
| TableCell |

the plain-text excerpt becomes Paragraph Heading Broken Line TableCell TableCell instead of ParagraphHeadingBrokenLineTableCellTableCell.

Related Issues

Fixes #14528.

Fixes excerpt generation (in plain text mode) to add spaces between text-bearing block-level elements (i.e. paragraphs, headings, table cells) as well as line breaks.
@mxxk mxxk requested a review from a team as a code owner June 22, 2019 01:18
@mxxk
Copy link
Contributor Author

mxxk commented Jun 30, 2019

cc @freiksenet

@Yihwan
Copy link

Yihwan commented Jul 2, 2019

Woohoo!

@Yihwan
Copy link

Yihwan commented Jul 4, 2019

@mxxk @freiksenet any chance this might get merged soon?

@mxxk
Copy link
Contributor Author

mxxk commented Jul 4, 2019

@Yihwan I'm waiting on approval 🙂

Copy link
Contributor

@pieh pieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added tests are awesome! Let's ship it!

@pieh pieh changed the title feat(gatsby-transformer-remark): Excerpt spacing fix(gatsby-transformer-remark): fix spaces between text-bearing block-level elements in plain text excerpts Jul 6, 2019
@pieh pieh merged commit 84ec96d into gatsbyjs:master Jul 6, 2019
@gatsbot
Copy link

gatsbot bot commented Jul 6, 2019

Holy buckets, @mxxk — we just merged your PR to Gatsby! 💪💜

Gatsby is built by awesome people like you. Let us say “thanks” in two ways:

  1. We’d like to send you some Gatsby swag. As a token of our appreciation, you can go to the Gatsby Swag Store and log in with your GitHub account to get a coupon code good for one free piece of swag. We’ve got Gatsby t-shirts, stickers, hats, scrunchies, and much more. (You can also unlock even more free swag with 5 contributions — wink wink nudge nudge.) See gatsby.dev/swag for details.
  2. We just invited you to join the Gatsby organization on GitHub. This will add you to our team of maintainers. Accept the invite by visiting https://github.com/orgs/gatsbyjs/invitation. By joining the team, you’ll be able to label issues, review pull requests, and merge approved pull requests.

If there’s anything we can do to help, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’.

Thanks again!

@pieh
Copy link
Contributor

pieh commented Jul 6, 2019

Published [email protected]

johno pushed a commit to johno/gatsby that referenced this pull request Jul 17, 2019
…-level elements in plain text excerpts (gatsbyjs#15040)

Fixes excerpt generation (in plain text mode) to add spaces between text-bearing block-level elements (i.e. paragraphs, headings, table cells) as well as line breaks.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Excerpt lacks space between paragraphs
3 participants