-
Notifications
You must be signed in to change notification settings - Fork 10.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Netlify deploy failing (Invalid filename 'icons/icon-96x96.png?v=a19f3881b4ae7f39c6f8740545bdbfb6915cf4b0'. Deployed filenames cannot contain # or ? characters) #12754
Comments
@jakeherp Thanks for the report. I wrote that cache busting code and will see if I can reproduce. Is there any more context for that error? That should be the url link provided in the html head, not the actual file name I'm not sure from this error which it's complaining about. It is possible Netlify doesn't support url queries on files. Cache busting can be set to It might not be needed for netlify: https://www.netlify.com/blog/2015/09/11/instant-cache-invalidation/ |
I will note that The gatsbyjs.org site is on Netlify and using query base cache busting with no problem. Though maybe someone already made a work around. |
@jakeherp I just deployed the default gatsby starter no problem. If you could post your env info using |
The full log from Netlify is:
I am now not in the office, from where I have had the issue, but the system report for my Macbook with the same configuration is:
My configuration for
|
Looks like it is the file names it's complaining about. I'll see if in can re-create this. Send me the config if you get a chance. |
Sorry, missed your previous message. Which config do you need? |
Manifest plugin config - but I just saw you posted it above. Looks like we both missed something. I'll take a look in to morning |
Great, thank you! |
@jakeherp I'm unable to reproduce this. I've read the through the logic multiple times, it seems to be correct. If you can post a repo this is happening on then maybe we can go from there. If you can't post your production repo maybe make a copy and rip out all the custom work and just leave the plugins and configs, deploy it to netlify and confirm your issue is still happening. Otherwise I'd make sure you're not committing |
I can't reproduce it in my local environment myself, yet it fails on Netlify.
Netlify support wrote:
I have done all that, still can't reproduce the same result, even when using their Docker container. The repo for my project can be found here. Thanks again for your help! |
@jakeherp Yeah, I've been try to reproduce on Netlify. 2.0.24 is where the cache busting feature got added, so this makes sense. Should have been a minor tick and not patch but oh well. I'll try with your repo and go from there. |
@jakeherp https://github.com/jakeherp/gatsby-portfolio/blob/master/gatsby-config.js -- Your |
Gosh, I'm sorry for keeping you busy with that! Didn't realise that I had it in there twice. |
@jakeherp Glad we figured it out and always happy help! |
Description
Since a couple of days ago it keeps failing to deploy to Netlify with the following error:
8:20:02 AM: failed during stage 'deploying site': Invalid filename 'icons/icon-96x96.png?v=a19f3881b4ae7f39c6f8740545bdbfb6915cf4b0'. Deployed filenames cannot contain # or ? characters
I have confirmed this to be a problem with
gatsby-plugin-manifest
by locking its version to 2.0.18. In 2.0.18 it compiles fine.Steps to reproduce
Cannot reproduce the issue locally, even using Netlify's own Docker container. Files do not get generated with query strings in my local environment.
Expected result
Gatsby project gets built and served on Netlify server.
Actual result
Deploy failing due to query string in icon filename.
The text was updated successfully, but these errors were encountered: