Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gatsby-plugin-canonical-urls query params and hash #12709

Closed
MarkSalabutin opened this issue Mar 21, 2019 · 7 comments
Closed

gatsby-plugin-canonical-urls query params and hash #12709

MarkSalabutin opened this issue Mar 21, 2019 · 7 comments
Labels
type: question or discussion Issue discussing or asking a question about Gatsby

Comments

@MarkSalabutin
Copy link

Could you let me know why you added location.hash and location.search to canonical url? I faced with a problem that search engines treat pages example.com/page and example.com/page?search=query as different, but in practice, they are the same.

@sidharthachatterjee
Copy link
Contributor

From what I understand location.hash is ignored by most search engines and location.search should be included because its values often represent unique pages.

@sidharthachatterjee sidharthachatterjee added the type: question or discussion Issue discussing or asking a question about Gatsby label Mar 22, 2019
@MarkSalabutin
Copy link
Author

But what about cases when location.search don't represent unique page? For example, fbclid which facebook add to every external link. If canonical URL includes that parameter search engine will treat this URL as a different page.

@sidharthachatterjee
Copy link
Contributor

@MarkSalabutin That’s a fair. We could add options to configure this, I suppose. Would you like to pick this up?

@gatsbot
Copy link

gatsbot bot commented Apr 12, 2019

Hiya!

This issue has gone quiet. Spooky quiet. 👻

We get a lot of issues, so we currently close issues after 30 days of inactivity. It’s been at least 20 days since the last update here.

If we missed this issue or if you want to keep it open, please reply here. You can also add the label "not stale" to keep this issue open!

Thanks for being a part of the Gatsby community! 💪💜

@gatsbot gatsbot bot added the stale? Issue that may be closed soon due to the original author not responding any more. label Apr 12, 2019
@Ehesp
Copy link
Contributor

Ehesp commented Apr 13, 2019

@MarkSalabutin @sidharthachatterjee just submitted a PR for this as I also ran into this issue. Would be good to get feedback.

@gatsbot
Copy link

gatsbot bot commented Apr 24, 2019

Hey again!

It’s been 30 days since anything happened on this issue, so our friendly neighborhood robot (that’s me!) is going to close it.

Please keep in mind that I’m only a robot, so if I’ve closed this issue in error, I’m HUMAN_EMOTION_SORRY. Please feel free to reopen this issue or create a new one if you need anything else.

Thanks again for being part of the Gatsby community!

@gatsbot gatsbot bot closed this as completed Apr 24, 2019
@sidharthachatterjee sidharthachatterjee added not stale and removed stale? Issue that may be closed soon due to the original author not responding any more. labels Apr 25, 2019
@LekoArts
Copy link
Contributor

fixed by #13339

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: question or discussion Issue discussing or asking a question about Gatsby
Projects
None yet
Development

No branches or pull requests

4 participants