-
Notifications
You must be signed in to change notification settings - Fork 10.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(gatsby-transformer-remark): Handle headings with nested text #11881
fix(gatsby-transformer-remark): Handle headings with nested text #11881
Conversation
}`, | ||
node => { | ||
expect(node).toMatchSnapshot() | ||
expect(node.headings).toEqual([ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice idea here with this failing test 👏
I'm sorry I missed this one before #11888 # An **important** heading with `inline code` and text |
@diegohaz I'll close #11888 in favor of this. We probably want to use |
Thank you @stefanprobst. Added a test case with your example and fixed with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @diegohaz 👍
Holy buckets, @diegohaz — we just merged your PR to Gatsby! 💪💜 Gatsby is built by awesome people like you. Let us say “thanks” in two ways:
If there’s anything we can do to help, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’. Thanks again! |
Published in [email protected] |
Description
Here's a fix. If there's a better way to write the solution, just let me know.
Related Issues
Fixes #11879