-
Notifications
You must be signed in to change notification settings - Fork 10.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Autogenerate lock files for starters #10607
Comments
@DSchau just made a great point about how we don't supply a |
@sidharthachatterjee just discovered I haven't validated this much at all, but it works with the |
For context, the only reason we include a lock file at all (we didn't for a while) is the npm has the adorable behavior that if you install dependencies with yarn but then install a package with npm, npm not seeing a package-lock.json file will assume that everything in node_modules isn't needed and then delete those and only install the one new package. We used to get tons of issues from people complaining that gatsby didn't work after a while when going through the tutorial or trying it out. So deterministic installs isn't the goal, the goal is helping npm avoid deleting all someone's packages. What would also help is if we let people choose to use NPM or yarn as then "gatsby new" could choose one or the other and then we could avoid lock files altogether. |
Hiya! This issue has gone quiet. Spooky quiet. 👻 We get a lot of issues, so we currently close issues after 30 days of inactivity. It’s been at least 20 days since the last update here. If we missed this issue or if you want to keep it open, please reply here. You can also add the label "not stale" to keep this issue open! Thanks for being a part of the Gatsby community! 💪💜 |
@sidharthachatterjee any updates on this? I was just about to file an issue about
which is related to this. As I see it, there are two solutions to this, either remove the lock file that is not used during |
Sorry for missing this comment @JacobBlomgren I've tagged you in #13210 with a potential solution in case you're still interested in taking a stab at this! |
We now include both |
Now that starters are in this repo courtesy of @DSchau, @pieh and I were discussing how we ought to autogenerate lock files for them since manually updating dependencies is a chore.
package.json
for all starters have all dependencies specified with the^
selector so it's only the lock files that needs updating.The text was updated successfully, but these errors were encountered: