feat(gatsby-transformer-remark): support raw HTML in markdown excerpts #10499
Conversation
… from plugins like prismjs are not escaped
|
@DSchau Any chance you be my reviewer again? :) I think this should be a pretty straight-forward one |
|
Will do! I’ll check this out tomorrow morning! |
|
@nadrane ugh, sorry--didn't get to this today. One thing I thought would be helpful is updating |
|
Yeah I can definitely do that. Are you thinking I would just add a markdown document that uses raw html? |
|
@nadrane exactly, yeah! Not a blocker for this PR by any means, but it's a nice thing to show/document! |
|
@DSchau Hey, when you have a moment, I would love to get this guy reviewed :) |
|
Hi @DSchau and @nadrane. BTW. First I wanted to fix this error myself, only later I started to look for issue for related problem and therefore I have a proposal: @DSchau Have you thought about creating labels for plugins, for example |
Sure--this seems reasonable! I'll make a note of it and circle back with the team to see if it makes sense. Thanks! As far as this PR goes--last I recall it was ready to go. An example (e.g. using-remark) would be nice to have but not necessary as I said earlier! For now--let's just get this merged, and we can add that example at some later date. Thanks! |
DSchau
changed the title
|
gatsbyjs#10499) fix issue gatsbyjs#10498 The first commit was to fix some tests that were just totally not working. We weren't correctly passing around all of our pluginOptions. The second commit added a test that validated that `code` tags worked at all. Mostly a sanity check for me. Doesn't add a ton of value overall. The third commit the fix. One thing to note here is that I don't actually have a test for this issue. Off the top of my head, I'm not 100% sure how to test it. Maybe inserting raw HTML into the excerpt and expecting it to not get escaped would work? EDIT: Just added a test that makes sure we can render raw html in excerpts and replaced the less useful test from before.
fix issue #10498
The first commit was to fix some tests that were just totally not working. We weren't correctly passing around all of our pluginOptions.
The second commit added a test that validated that
codetags worked at all. Mostly a sanity check for me. Doesn't add a ton of value overall.The third commit the fix.
One thing to note here is that I don't actually have a test for this issue. Off the top of my head, I'm not 100% sure how to test it. Maybe inserting raw HTML into the excerpt and expecting it to not get escaped would work?
EDIT: Just added a test that makes sure we can render raw html in excerpts and replaced the less useful test from before.