Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Play next" for artists and albums #269

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Whateverest
Copy link

Hi, thanks for the great App!

The "Play Next" function currently only works for individual tracks.
I was used to having this feature for whole albums and artist as well, so I implemented it in my fork.
I tested it on my personal device and with an emulator - it seems to work fine.

I think the "most interesting" part of the code (meaning the one most likely to have bugs), is the new method: PlaybackService.enqueueAsNextTracks.

The implementation borrows from both the enqueueTrackAsNext and the enqueueTracks methods.
Songs are added after the current playing song, but if no song is currently playing, the newly enqueued album won't start playing (like it would when enqueuing tracks via enqueueTrackAsNext).

Are you interested in integrating this into odyssey?
If not, feel free to close this PR :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant