Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

develop <-> eth-rollup-develop alignment #686

Merged
merged 62 commits into from
Feb 7, 2024

Conversation

mateuszaaa
Copy link
Member

@mateuszaaa mateuszaaa commented Feb 6, 2024

should be merge after #674

mateuszaaa and others added 30 commits November 27, 2023 20:03
stop including txs into the block when annotated weight of extrinsics
exceeds block limits
I fixed 3 typos in this file:

Typo in "generat" should be "generate", "Compilie" should be "Compile" and "Managata" should be "Mangata".
@mateuszaaa mateuszaaa added the draft something not ready to be merged label Feb 6, 2024
@mateuszaaa mateuszaaa removed the draft something not ready to be merged label Feb 7, 2024
Copy link

codecov bot commented Feb 7, 2024

Codecov Report

Attention: 31 lines in your changes are missing coverage. Please review.

Comparison is base (01f6e9c) 48.48% compared to head (d258178) 48.39%.

Files Patch % Lines
pallets/metamask-signature-rpc/src/lib.rs 0.00% 22 Missing ⚠️
pallets/metamask-signature-runtime-api/src/lib.rs 0.00% 7 Missing ⚠️
node/src/rpc.rs 0.00% 2 Missing ⚠️
Additional details and impacted files
@@                  Coverage Diff                   @@
##           eth-rollup-develop     #686      +/-   ##
======================================================
- Coverage               48.48%   48.39%   -0.10%     
======================================================
  Files                      41       42       +1     
  Lines                    7383     7397      +14     
======================================================
  Hits                     3580     3580              
- Misses                   3803     3817      +14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mateuszaaa mateuszaaa merged commit 71abd93 into eth-rollup-develop Feb 7, 2024
46 of 49 checks passed
@mateuszaaa mateuszaaa deleted the eth-rollup-develop-metamask branch February 7, 2024 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants