Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement request: control Nginx settings, support multiple virtaul hosts within a single service and allow single controller for all modes #18

Open
tmeltser opened this issue Jul 6, 2024 · 2 comments

Comments

@tmeltser
Copy link

tmeltser commented Jul 6, 2024

Hi,
We have been trying the swarm ingress for the last few days and we have found it very useful - a job well done crafting this addon...

During the engagement, we came across the follwoing challenges, ordered by importance:

  1. It seems the default Nginx upload limit is very limited, we got blocked with an upload of 4MB docker image (putting Nexus (as a docker registry) behind the controller). It would be very helpfull if at least some of the configuration of the Nginx would be exposed for us to control. For example in K8S, with Nginx ingress controller, we control the following settings:
  • proxy-body-size: "2g"
  • proxy-connect-timeout: "3600"
  • proxy-read-timeout: "3600"
  • proxy-send-timeout: "3600"
  • enable-access-log-for-default-backend: "true"
  • ssl-redirect: "true"
  • use-http2: "true"
  • use-forwarded-headers: "true"
  • compute-full-forwarded-for: "true"
  1. Specifically in the Nexus case, we have 2 ports exposed, 8081 for the GUI and 7071 for docker registry - it would be very helpfull if we could use the ingress related labels multiple times in a service, one for each designated port
  2. Last but not least, if there is a way to have a single controller that supports all the modes (passthrough and offload/bridge), while moving the mode selection to labels on the service side, that would be quite useful...

If some, or even all of these challenges could be resolved, I think it would benefit the majority of the users of this excellent tool/addon
(beside us of course)...

@tmeltser tmeltser changed the title Enhancement request: control Nginx settings, support multiple virtaul hosts within a service and allow single controller for all modes Enhancement request: control Nginx settings, support multiple virtaul hosts within a single service and allow single controller for all modes Jul 6, 2024
@garutilorenzo
Copy link
Owner

Hello @tmeltser,

I think 1 and 3 are feature that I can implement.
For 2, port 7071 is a TCP port? What is exposed on this port? Is that an http service or a tcp service?

@tmeltser
Copy link
Author

Hi @garutilorenzo,
Thank you for the prompt (and positive) reply, I've have missed it and hense my delayed answer:
As for item 2, this is an HTTP or HTTPS port on which the Nexus exposes its container registry. If we had a support for multiple virtual hosts (maybe I'm using the wrong term here), and we could define the set of labels (of the ingress controller) for both the main port (8081) and the container registry one (7071 in our exmple), then I would gladly define the 7071 as an HTTP port, and let the ingress controller do the SSL/TLS offloading...
I hope that clarifies the issue (I'm sure there are other cases where a service might need to expose more than one port)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants