Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Newbie question #2

Open
chiacy opened this issue Mar 12, 2020 · 0 comments
Open

Newbie question #2

chiacy opened this issue Mar 12, 2020 · 0 comments

Comments

@chiacy
Copy link

chiacy commented Mar 12, 2020

Hi!

Thank you for sharing this piece of your work.

I tried using it on my site and I have the following issues:

let mappings = { MRec1_HOME_MY: [ { window: [0, 0], sizes: [ [320, 250] ] } ], MRec2_HOME_MY: [ { window: [0, 0], sizes: [ [300, 251] ] }, { window: [980, 0], sizes: [ [300, 251] ] } ], Leaderboard_Home_MY: [ { window: [0, 0], sizes: [ [728, 90] ] } ], ButtonSide_MY_Home: [ { window: [0, 0], sizes: [ [300, 100] ] } ] }

I defined mappings as above,

let sizes = { MRec1_HOME_MY: [ [320, 250] ], MRec2_HOME_MY: [ [300, 251] ], Leaderboard_Home_MY: [ [728, 90] ], ButtonSide_MY_Home: [ [300, 100] ], rectangle: [ [300, 252] ] }

sizes

then I use the component as below:

<div id="Leaderboard_Home_MY"> <google-ad unit="Leaderboard_Home_MY" id="1488450959740-1"> </google-ad> </div>

Am not sure why the result code on browser as follow:

Incorrect usage of googletag.Slot defineSizeMapping: Size mapping has to be an array

<div id="Leaderboard_Home_MY"><div id="1488450959740-1" data-google-query-id="CLGE9KSPlegCFU6JaAoddj8LSQ" style="display: none;"><div id="google_ads_iframe_/9457649/Leaderboard_Home_MY_0__container__" style="border: 0pt none; width: 300px; height: 252px;"></div></div></div>

please note that the size is 300px X 252px respectively, but was defined both on google ad manager and the above codes for Leaderboard_HOME_MY as 720 x 90

wonder if you can point out where the problem is?

thanks In advance

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant