Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Record Metrics for AWS API calls #156

Open
rishabh-11 opened this issue Jan 26, 2024 · 0 comments
Open

Record Metrics for AWS API calls #156

rishabh-11 opened this issue Jan 26, 2024 · 0 comments
Labels
kind/enhancement Enhancement, improvement, extension

Comments

@rishabh-11
Copy link
Contributor

rishabh-11 commented Jan 26, 2024

What would you like to be added:
In version v0.50.0 of MCM new metrics were added to record cloud provider api request durations and failures. It is for the provider's to implement the logic of updating these metrics at the appropriate points in the code base based on their driver activity with the provider.

As a part of this issue, the provider needs to record requests_failed_total, requests_total and api_request_duration_seconds metrics. Refer mcm-provider-az repo to see how they are implemented for Azure API calls.

Why is this needed:
Corresponding MCM issue :- gardener/machine-controller-manager#872

@rishabh-11 rishabh-11 added the kind/enhancement Enhancement, improvement, extension label Jan 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Enhancement, improvement, extension
Projects
None yet
Development

No branches or pull requests

1 participant