[Feature] Validate/default fields of HVPA CRD in v2 using webhooks #84
Labels
kind/enhancement
Enhancement, improvement, extension
lifecycle/rotten
Nobody worked on this for 12 months (final aging stage)
Feature (What you would like to be added):
We should validate/default fields of HVPA CRD in v2 (according to the redesign proposal) using validating/default webhooks.
Things to validate:
maintenanceTimeWindow
should be configured if update modeMaintenanceWindow
is used.minReplicas
andmaxReplicas
in the HPA template should matchmaxReplicas
of the first and the last effective scaling intervals.maxCPU
andmaxMemory
of the last effective scaling intervals.minChange
configuration (forscaleUp
andscaleDown
) should keep such that the recommendations blocked due tominChange
configuration should be below the limits as configured inlimitsRequestsGapScaleParams
(or VPA's proportional limit scaling iflimitsRequestsGapScaleParams
has not been configured).Things to default:
updateMode
Auto
if none given.minReplicas
andmaxReplicas
of HPA template (if configured) to correspond to themaxReplicas
of the first and the last effective scaling intervals,maxCPU
andmaxMemory
of the last effective scaling intervals to correspond to VPA templates' maxAllowed if configured.Motivation (Why is this needed?):
To improve user experience and to reduce the chances of misconfiguration.
Approach/Hint to the implement solution (optional):
Considering that the HVPA v2 branch is yet to be merged to master, this change can be done on top of hvpa-v2 branch and later rebased on master and merged.
The text was updated successfully, but these errors were encountered: