Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Empty namePrefix should be caught by validator #449

Open
briantopping opened this issue Jul 24, 2023 · 0 comments
Open

Empty namePrefix should be caught by validator #449

briantopping opened this issue Jul 24, 2023 · 0 comments
Labels
area/robustness Robustness, reliability, resilience related kind/enhancement Enhancement, improvement, extension lifecycle/stale Nobody worked on this for 6 months (will further age) platform/vsphere VMware vSphere platform/infrastructure

Comments

@briantopping
Copy link
Member

How to categorize this issue?

/area robustness
/kind enhancement
/platform vsphere

What happened:
Creating a CloudProfile with an empty namePrefix in the vSphere configuration block results in failure to create a shoot. The error message is sufficient, but can we improve a validator somewhere that avoids this issue? If not, can we generate a namePrefix from the combination of an existing name in context plus a random string?

What you expected to happen:
Don't require a CloudProfile update to fix a misconfiguration, which is expensive via LSS.

How to reproduce it (as minimally and precisely as possible):
Leave namePrefix blank, try to create a cluster.

cc: @marwinski

@gardener-robot gardener-robot added area/robustness Robustness, reliability, resilience related kind/enhancement Enhancement, improvement, extension platform/vsphere VMware vSphere platform/infrastructure labels Jul 24, 2023
@gardener-robot gardener-robot added the lifecycle/stale Nobody worked on this for 6 months (will further age) label Jul 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/robustness Robustness, reliability, resilience related kind/enhancement Enhancement, improvement, extension lifecycle/stale Nobody worked on this for 6 months (will further age) platform/vsphere VMware vSphere platform/infrastructure
Projects
None yet
Development

No branches or pull requests

2 participants