Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit tests #204

Closed
briantopping opened this issue Jan 29, 2022 · 1 comment
Closed

Unit tests #204

briantopping opened this issue Jan 29, 2022 · 1 comment
Assignees
Labels
kind/enhancement Enhancement, improvement, extension platform/vsphere VMware vSphere platform/infrastructure status/closed Issue is closed (either delivered or triaged)

Comments

@briantopping
Copy link
Member

briantopping commented Jan 29, 2022

How to categorize this issue?
/kind enhancement
/platform vsphere

What would you like to be added: Convert API usage to govmomi, add unit tests that operate against vcsim (subproject).

Why is this needed
The project currently has integration tests (against an actual vSphere instance), but not project scoped unit tests that can be run in a sandboxed Concourse CI context. While integration tests always have some value, it will prove very difficult to validate the full Gardener test matrix over different versions of vSphere with only integration tests.

This enhancement proposes to use vcsim to simulate vSphere API levels in the Gardener test matrix. vcsim allows inventory to be saved as a data file, these data files would be stored in the project tree and sequentially checked during test execution. In some cases, problematic vSphere inventory configurations will be sufficient to trigger failure without writing new unit tests. These problematic configurations will act as regression guards for future project work.

#206 addresses how the release patterns could be updated to take advantage of focused API version testing.

@briantopping briantopping added the kind/enhancement Enhancement, improvement, extension label Jan 29, 2022
@briantopping briantopping self-assigned this Jan 29, 2022
@gardener-robot gardener-robot added the platform/vsphere VMware vSphere platform/infrastructure label Jan 29, 2022
@briantopping briantopping changed the title Use github.com/vmware/govmomi Unit tests Feb 1, 2022
@gardener gardener deleted a comment from gardener-robot Feb 1, 2022
@gardener gardener deleted a comment from gardener-robot Feb 1, 2022
@gardener-robot gardener-robot added the lifecycle/stale Nobody worked on this for 6 months (will further age) label Aug 1, 2022
@gardener-robot gardener-robot added lifecycle/rotten Nobody worked on this for 12 months (final aging stage) and removed lifecycle/stale Nobody worked on this for 6 months (will further age) labels Jan 28, 2023
@briantopping briantopping removed the lifecycle/rotten Nobody worked on this for 12 months (final aging stage) label Feb 8, 2023
@briantopping
Copy link
Member Author

Closing and rebuilding the epic around testing

@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Feb 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Enhancement, improvement, extension platform/vsphere VMware vSphere platform/infrastructure status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Development

No branches or pull requests

2 participants