Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clashing VPA dependencies between etcd-druid and gardener/gardener #788

Closed
shreyas-s-rao opened this issue Apr 25, 2024 · 0 comments · Fixed by #844
Closed

Clashing VPA dependencies between etcd-druid and gardener/gardener #788

shreyas-s-rao opened this issue Apr 25, 2024 · 0 comments · Fixed by #844
Labels
area/dev-productivity Developer productivity related (how to improve development) kind/impediment Something that impedes developers, operators, users or others in their work status/closed Issue is closed (either delivered or triaged)
Milestone

Comments

@shreyas-s-rao
Copy link
Contributor

How to categorize this issue?

/area dev-productivity
/kind impediment

What happened:
As a developer, I work on both etcd-druid as well as gardener/gardener on my local machine. With the latest change in druid from #748 , the vendor folder is removed, and dependencies are vendored to the go mod cache. Since master branch of g/g uses dependency k8s.io/autoscaler/vertical-pod-autoscaler v1.0.0 and etcd-druid uses indirect dependency k8s.io/autoscaler v0.0.0-20190805135949-100e91ba756e // indirect from an older version of g/g, there seems to be an issue with my GoLand IDE in resolving the correct vpa dependency for g/g. Instead of using k8s.io/autoscaler/[email protected] from the go mod cache, it seems to be resolving to k8s.io/autoscaler v0.0.0-20190805135949-100e91ba756e/vertical-pod-autoscaler by default, which causes linter errors for g/g.

I would like to bring the indirect vpa dependency in etcd-druid to the same version as the g/g dependnecy it vendors, ie, k8s.io/autoscaler/vertical-pod-autoscaler v1.0.0.

How to reproduce it (as minimally and precisely as possible):
Checkout current etcd-druid master and g/g master and run make tidy on both.

@gardener-robot gardener-robot added area/dev-productivity Developer productivity related (how to improve development) kind/impediment Something that impedes developers, operators, users or others in their work labels Apr 25, 2024
@shreyas-s-rao shreyas-s-rao added this to the v0.23.0 milestone Apr 25, 2024
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Jul 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/dev-productivity Developer productivity related (how to improve development) kind/impediment Something that impedes developers, operators, users or others in their work status/closed Issue is closed (either delivered or triaged)
Projects
None yet
2 participants