Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Propagate DeltaSnapshotRetentionPeriod Flag to etcd-backup-restore #650

Closed
Tracked by #621
seshachalam-yv opened this issue Jul 29, 2023 · 2 comments
Closed
Tracked by #621
Assignees
Labels
kind/enhancement Enhancement, improvement, extension status/closed Issue is closed (either delivered or triaged)
Milestone

Comments

@seshachalam-yv
Copy link
Contributor

Feature (What you would like to be added):
Modify etcd-druid to propagate the --delta-snapshot-retention-period flag from the Etcd CRD to the etcd-backup-restore component.

Motivation (Why is this needed?):
The etcd-backup-restore component has recently introduced a --delta-snapshot-retention-period flag (PR #640). This flag allows users to customize the retention period for delta snapshots, providing more flexibility for both Exponential and Limit-Based GC policies. To leverage this feature in etcd-druid, we need to modify etcd-druid to propagate this flag to the etcd-backup-restore component.

Approach/Hint to the implement solution (optional):

@seshachalam-yv
Copy link
Contributor Author

/assign

@shreyas-s-rao
Copy link
Contributor

This has been completed as part of #651
/close

@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Aug 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Enhancement, improvement, extension status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Development

No branches or pull requests

3 participants