You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Time encoder:
The date-time format used in etcd-druid makes it impossible to know the date and time.
We have always used the default time encoder and recently a PR#450 bumped up the controller-runtime version. We also see the following issue kubernetes-sigs/controller-runtime#2029 which highlights that the default encoder is epoch time and the PR fixes that. Ideally we should not assume that the correct defaults are set and explicitly define the encoder while initialising the logger.
Structured Logging and add context.
Both logr and the underline zap provides for structured logging. Check if this is used consistently and correct anywhere it is not. Logs such as Custodian controller reconciliation started does not provide any benefit. Additional context should be provided.
Expected behavior:
Date and time should be clearly distinguished and visible for all log statements emitted. Structure logging should be used where parameters are passed.
The text was updated successfully, but these errors were encountered:
Describe the bug:
Reference: https://sap-ti.slack.com/archives/C0177NLL8V9/p1676014983819069
Time encoder:
The date-time format used in etcd-druid makes it impossible to know the date and time.
We have always used the default time encoder and recently a PR#450 bumped up the controller-runtime version. We also see the following issue kubernetes-sigs/controller-runtime#2029 which highlights that the default encoder is epoch time and the PR fixes that. Ideally we should not assume that the correct defaults are set and explicitly define the encoder while initialising the logger.
Structured Logging and add context.
Both logr and the underline zap provides for structured logging. Check if this is used consistently and correct anywhere it is not. Logs such as
Custodian controller reconciliation started
does not provide any benefit. Additional context should be provided.Expected behavior:
Date and time should be clearly distinguished and visible for all log statements emitted. Structure logging should be used where parameters are passed.
The text was updated successfully, but these errors were encountered: