Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Remove the use of Render method of the chartrenderer.Interface #454

Closed
AleksandarSavchev opened this issue Oct 27, 2022 · 1 comment
Labels
kind/enhancement Enhancement, improvement, extension lifecycle/rotten Nobody worked on this for 12 months (final aging stage) priority/4 Priority (lower number equals higher priority) status/closed Issue is closed (either delivered or triaged)

Comments

@AleksandarSavchev
Copy link
Member

Feature (What you would like to be added):
I would like the use of Render method of the chartrenderer.Interface to be removed from this project (currently used in ./controllers/etcd_controller.go and ./controllers/etcdcopybackupstack_controller.go)

Motivation (Why is this needed?):
The Render method is deprecated in favour of RenderEmbeddedFS and will be removed in the future. For more info check this PR.

Approach/Hint to the implement solution (optional):
The current Render method can be replaced by RenderEmbeddedFS with some changes to file structure or the code can be refactored without the use of these methods.

@AleksandarSavchev AleksandarSavchev added the kind/enhancement Enhancement, improvement, extension label Oct 27, 2022
@abdasgupta abdasgupta added the priority/4 Priority (lower number equals higher priority) label Jan 6, 2023
@gardener-robot gardener-robot added the lifecycle/stale Nobody worked on this for 6 months (will further age) label Sep 15, 2023
@gardener-robot gardener-robot added lifecycle/rotten Nobody worked on this for 12 months (final aging stage) and removed lifecycle/stale Nobody worked on this for 6 months (will further age) labels May 24, 2024
@shreyas-s-rao
Copy link
Contributor

We have refactored most of etcd-druid codebase now, and the controllers no longer render helm charts. Instead, we use the ResourceOperator model (similar to the g/g component model) to reconcile k8s resources, so we have gotten rid of usage of chartrenderer package. This issue can now be closed.

/close

@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Enhancement, improvement, extension lifecycle/rotten Nobody worked on this for 12 months (final aging stage) priority/4 Priority (lower number equals higher priority) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Development

No branches or pull requests

4 participants