Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backup Restore https server should be mTLS enabled #814

Open
anveshreddy18 opened this issue Dec 19, 2024 · 1 comment
Open

Backup Restore https server should be mTLS enabled #814

anveshreddy18 opened this issue Dec 19, 2024 · 1 comment
Labels
kind/enhancement Enhancement, improvement, extension

Comments

@anveshreddy18
Copy link
Contributor

Enhancement (What you would like to be added):

Backup Restore https server should be mTLS enabled

Motivation (Why is this needed?):

Currently the backup-restore https server is only TLS enabled, I would like it to be mTLS where the server also verifies the client certificates to enhance the security.

In the Gardener landscapes, we do generate the client certificates to be used by clients connecting to backup-restore server and is mounted to the respective container but the backup-restore server is not configured to verify client's identity thus the cert-key pair is rendered useless.

When deployed through druid, the clients that currently connect to the backup-restore container is only etcd-wrapper which triggers the initialisation procedure, getting etcd config, etc. But, in future there are plans to take out of schedule snapshots from etcd-druid as well for which it needs to make the api request to the backup-restore server, so making the server mTLS makes more sense keeping the future plans in mind.

Approach/Hint to the implement solution (optional):

@anveshreddy18 anveshreddy18 added the kind/enhancement Enhancement, improvement, extension label Dec 19, 2024
@unmarshall
Copy link
Contributor

unmarshall commented Jan 2, 2025

Is mTLS is required at this stage given that the server is only being consumed by etcd-wrapper?

But, in future there are plans to take out of schedule snapshots from etcd-druid as well for which it needs to make the api request to the backup-restore server, so making the server mTLS makes more sense keeping the future plans in mind.

Why do we assume that etcd-druid is going to make a direct HTTPs call to etcd-backup-restore server to take full snapshots? When the operator tasks are implemented there will be CR created for every task which will be accessible also from within etcd-backup-restore container which will then update the status of these tasks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Enhancement, improvement, extension
Projects
None yet
Development

No branches or pull requests

2 participants