Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Extend Retention Period for Delta Snapshots #639

Closed
Tracked by #621
seshachalam-yv opened this issue Jun 26, 2023 · 1 comment · Fixed by #640
Closed
Tracked by #621

[Feature] Extend Retention Period for Delta Snapshots #639

seshachalam-yv opened this issue Jun 26, 2023 · 1 comment · Fixed by #640
Assignees
Labels
kind/enhancement Enhancement, improvement, extension status/closed Issue is closed (either delivered or triaged)

Comments

@seshachalam-yv
Copy link
Contributor

Feature (What you would like to be added):

We need to make the retention period for delta snapshots configurable to ensure we can provide enough data for operators to troubleshoot effectively.

Motivation (Why is this needed?):

Currently, delta snapshots are only retained for latest delta snapshots While this might be adequate for some situations, it could prove insufficient for debugging issues or bugs in productive environments where a longer retention period could be necessary.

Approach/Hint to the implement solution (optional):

Implement the DeltaSnapshotRetentionPeriod parameter in the SnapshotterConfig structure to support configurability of the retention period for delta snapshots. This parameter should be adjustable via command-line flags. Modify the garbage collection logic for both Exponential and LimitBased policies to use this retention period, thereby skipping the deletion of delta snapshots within this period. By doing so, both garbage collection policies will support the delta-snapshot-retention-period flag, ensuring user-specified retention of delta snapshots.

@seshachalam-yv seshachalam-yv added the kind/enhancement Enhancement, improvement, extension label Jun 26, 2023
@seshachalam-yv
Copy link
Contributor Author

/assign

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Enhancement, improvement, extension status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants