Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the component name from dashboard to gardener-dashboard #1857

Merged
merged 1 commit into from
May 14, 2024

Conversation

ialidzhikov
Copy link
Member

@ialidzhikov ialidzhikov commented May 7, 2024

What this PR does / why we need it:
Similar to gardener/terminal-controller-manager#294. See https://github.com/gardener/gardener/blob/a5714298df3366548b9cb82e26d28622e6cb7c76/imagevector/images.yaml#L43-L46

Which issue(s) this PR fixes:
N/A

Special notes for your reviewer:
N/A

Release note:

The component name is changed from `dashboard` to `gardener-dashboard`.

@gardener-robot gardener-robot added needs/review Needs review size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) labels May 7, 2024
@gardener-robot-ci-3 gardener-robot-ci-3 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels May 7, 2024
Copy link
Member

@holgerkoser holgerkoser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels May 8, 2024
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label May 8, 2024
Copy link
Contributor

@grolu grolu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@petersutter petersutter merged commit 463eff1 into gardener:master May 14, 2024
8 checks passed
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label May 14, 2024
holgerkoser added a commit that referenced this pull request May 14, 2024
* master:
  Some update message improvements (#1867)
  Update Yarn to v4.2.2 (#1853)
  Gracefully Handle Session Secret Changes for Seamless User Experience (#1869)
  Update dependency sass to v1.77.1 (#1865)
  Update actions/checkout action to v4.1.5 (#1860)
  Update dependency eslint-plugin-vue to v9.26.0 (#1861)
  Update dependency semver to v7.6.2 (#1863)
  Update the component name from `dashboard` to `gardener-dashboard` (#1857)
  Cherry picked fix for vuetify issue #19707 (#1868)

# Conflicts:
#	frontend/src/components/ShootAccessRestrictions/GAccessRestrictionChips.vue
#	frontend/src/components/ShootMessages/GShootMessages.vue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants