Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make oidc.clientSecret optional #1835

Merged
merged 2 commits into from
Apr 24, 2024

Conversation

petersutter
Copy link
Member

What this PR does / why we need it:
Values.global.dashboard.oidc.clientSecret is now optional. The dashboard can now also use a public OIDC client.

Which issue(s) this PR fixes:
Fixes #1812

Special notes for your reviewer:

Release note:

`Values.global.dashboard.oidc.clientSecret` is now optional. The dashboard can now also use a public OIDC client.

@gardener-robot gardener-robot added the needs/review Needs review label Apr 22, 2024
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Apr 22, 2024
@gardener-robot gardener-robot added the size/m Size of pull request is medium (see gardener-robot robot/bots/size.py) label Apr 22, 2024
@gardener-robot-ci-3 gardener-robot-ci-3 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Apr 22, 2024
@petersutter
Copy link
Member Author

cc @rfranzke

@petersutter petersutter force-pushed the enh/make-oidc-client-secret-optional branch from 5927f5d to bde299c Compare April 23, 2024 08:04
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Apr 23, 2024
@gardener-robot-ci-3 gardener-robot-ci-3 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Apr 23, 2024
Copy link
Contributor

@grolu grolu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Apr 23, 2024
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Apr 23, 2024
@gardener-robot-ci-2 gardener-robot-ci-2 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Apr 24, 2024
@petersutter petersutter merged commit 28db894 into master Apr 24, 2024
9 checks passed
@petersutter petersutter deleted the enh/make-oidc-client-secret-optional branch April 24, 2024 14:15
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Apr 24, 2024
holgerkoser added a commit that referenced this pull request Apr 29, 2024
* master:
  Update vitest monorepo to v1.5.2 (#1844)
  Promote `experimentalUseWatchCacheForListShoots` to stable (#1822)
  Update dependency supertest to v7 (#1843)
  Update vitest monorepo to v1.5.1 (#1840)
  Add hack/cherry-pick-pull.sh (#1831)
  Make OIDC clientSecret optional (#1835)
  Create `Lease` during runtime, if not found (#1823)
  Update actions/checkout action to v4.1.4 (#1841)
  Update dependency vuetify to v3.5.17 (#1839)
  Update actions/checkout action to v4.1.3 (#1834)
  Update dependency vue to v3.4.25 (#1837)
  Update renovate.json5
  migrate to new @xterm scoped packages (#1832)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging size/m Size of pull request is medium (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make oidc.clientSecret optional
6 participants