Terminal: show last error description on timeout
#1810
Merged
+38
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @dguendisch |
gardener-robot
added
the
size/s
gardener-robot-ci-2
added
the
reviewed/ok-to-test
gardener-robot-ci-1
added
needs/ok-to-test
petersutter
force-pushed
the
enh/terminal-erros
branch
from
a1d4840
to
6029cb5
Compare
gardener-robot-ci-3
added
reviewed/ok-to-test
|
@grolu, @holgerkoser You have pull request review open invite, please check |
petersutter
force-pushed
the
enh/terminal-erros
branch
from
6029cb5
to
b4eeb19
Compare
gardener-robot-ci-2
added
reviewed/ok-to-test
gardener-robot
added
reviewed/lgtm
gardener-robot-ci-2
added
the
reviewed/ok-to-test
gardener-robot-ci-1
removed
the
reviewed/ok-to-test
gardener-robot
added
the
status/closed
holgerkoser
added a commit
that referenced
this pull request
Apr 24, 2024
* master: (78 commits) remove `pragma: whitelist secret` comments (#1836) Ticket title should contain project name (#1824) Update dependency @fontsource/roboto to v5.0.13 (#1828) Update dependency vite to v5.2.10 (#1827) Update dependency jest-date-mock to v1.0.10 (#1829) `Terminal`: show last error description on timeout (#1810) Added support for machine image update strategy (#1807) Update dependency vue-router to v4.3.2 (#1821) Update dependency eslint-plugin-vue to v9.25.0 (#1811) Update renovate.json5 Update renovate.json5 Update renovate.json5 renovate: Ignore eslint major updates (#1819) Update dependency vuetify to v3.5.16 (#1818) Update dependency vue to v3.4.23 (#1817) Update dependency prom-client to v15.1.2 (#1814) Update dependency vite to v5.2.9 (#1815) Update dependency vue to v3.4.22 (#1813) Update dependency sass to v1.75.0 (#1809) Update vitest monorepo to v1.5.0 (#1808) ... # Conflicts: # .pnp.cjs # frontend/__tests__/stores/cloudProfile.spec.js # frontend/package.json # frontend/src/components/GSeedConfiguration.vue # frontend/src/components/GShootActionRotateCredentials.vue # frontend/src/components/GShootListRow.vue # frontend/src/components/GShootListRowActions.vue # frontend/src/components/NewShoot/GNewShootDetails.vue # frontend/src/components/ShootDetails/GShootDetailsCard.vue # frontend/src/components/ShootVersion/GShootVersion.vue # frontend/src/components/ShootWorkers/GManageWorkers.vue # frontend/src/components/ShootWorkers/GWorkerGroup.vue # frontend/src/mixins/shootItem.js # frontend/src/store/cloudProfile/index.js # frontend/src/utils/index.js # yarn.lock Resoved conflicts and fixed tests not yet tested
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
The last error description of the
Terminalresource is shown on timeout.Which issue(s) this PR fixes:
Fixes #1727
Special notes for your reviewer:
requires changes from gardener/terminal-controller-manager#281
Release note: