-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show route information in window title #1752
Conversation
@holgerkoser You have pull request review open invite, please check |
f834285
to
7b0b665
Compare
- Added project breadcrumb
7b0b665
to
2256181
Compare
- Project link to Project Cluster list - Clusters link to All Projects Cluster list
- Changed page title calcultion accordingly
9b83f74
to
e8e872e
Compare
frontend/src/App.vue
Outdated
const projectName = projectStore.projectName | ||
const routeParamName = route.params.name | ||
const pageTitle = route.meta.title ?? route.name | ||
|
||
let titleItems = [pageTitle] | ||
if (route.meta.namespaced !== false) { | ||
const locationTitle = [projectName, routeParamName].filter(item => item !== undefined).join('/') | ||
titleItems.push(locationTitle) | ||
} | ||
titleItems = titleItems.filter(item => item?.length) | ||
|
||
if (titleItems.length) { | ||
appTitle = `${titleItems.join(' • ')} | ${appTitle}` | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
const projectName = projectStore.projectName | |
const routeParamName = route.params.name | |
const pageTitle = route.meta.title ?? route.name | |
let titleItems = [pageTitle] | |
if (route.meta.namespaced !== false) { | |
const locationTitle = [projectName, routeParamName].filter(item => item !== undefined).join('/') | |
titleItems.push(locationTitle) | |
} | |
titleItems = titleItems.filter(item => item?.length) | |
if (titleItems.length) { | |
appTitle = `${titleItems.join(' • ')} | ${appTitle}` | |
} | |
const titleItems = [] | |
const pageTitle = route.meta.title ?? route.name | |
if (pageTitle) { | |
titleItems.push(pageTitle) | |
} | |
if (route.meta.namespaced !== false) { | |
const projectName = projectStore.projectName | |
const routeParamName = route.params.name | |
if (routeParamName) { | |
titleItems.push([projectName, routeParamName].join('/')) | |
} else if (projectName) { | |
titleItems.push(projectName) | |
} | |
} | |
if (titleItems.length) { | |
appTitle = `${titleItems.join(' • ')} | ${appTitle}` | |
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #1605
Special notes for your reviewer:
Release note: