Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[master] Make storage size configuration more explicit #1721

Merged
merged 3 commits into from
Feb 21, 2024

Conversation

grolu
Copy link
Contributor

@grolu grolu commented Feb 21, 2024

What this PR does / why we need it:
Enhanced Volume Management for OpenStack Workers
This Fix addresses and resolves a critical issue our users have experienced. Previously, updating OpenStack workers via the dashboard inadvertently led to the loss of custom volume sizes. This release brings a fix to this bug, ensuring that your custom volume configurations are retained post-update.
Additionally, we've improved the storage size configuration interface. Now, it's easier to distinguish between default and custom volumes, allowing for a more intuitive setup process. This enhancement aims to streamline your experience, making volume management more straightforward and error-free.

Screenshot 2024-02-21 at 17 37 05 Screenshot 2024-02-21 at 15 44 00

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

NONE

@gardener-robot gardener-robot added needs/review Needs review size/m Size of pull request is medium (see gardener-robot robot/bots/size.py) labels Feb 21, 2024
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Feb 21, 2024
@gardener-robot-ci-3 gardener-robot-ci-3 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Feb 21, 2024
@gardener-robot-ci-2 gardener-robot-ci-2 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Feb 21, 2024
Copy link
Member

@petersutter petersutter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Feb 21, 2024
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Feb 21, 2024
@gardener-robot-ci-1 gardener-robot-ci-1 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Feb 21, 2024
Copy link
Member

@holgerkoser holgerkoser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@grolu grolu merged commit e69e6f1 into master Feb 21, 2024
9 checks passed
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Feb 21, 2024
@grolu grolu deleted the bug/master_fix_volume_size branch February 21, 2024 16:52
holgerkoser added a commit that referenced this pull request Mar 7, 2024
* master:
  Do not double quote string in yaml config example (#1728)
  parse numerical abbreviations (#1719)
  [master] Make storage size configuration more explicit (#1721)
  License and reuse adaptions (#1718)
  Prepare next Development Cycle 1.74.0-dev
  Release 1.73.0
  rm tonal variant from worker cards (#1715)
  Fix viewer handling for secret name (#1714)
  Support viewer to download `gardenlogin` kubeconfig by fetching cluster CA via `ConfigMap` (#1708)
  removed force delete feature flag from dashboard configuration (#1713)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging size/m Size of pull request is medium (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants