-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[master] Make storage size configuration more explicit #1721
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petersutter
reviewed
Feb 21, 2024
petersutter
reviewed
Feb 21, 2024
petersutter
approved these changes
Feb 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
holgerkoser
reviewed
Feb 21, 2024
holgerkoser
approved these changes
Feb 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
holgerkoser
added a commit
that referenced
this pull request
Mar 7, 2024
* master: Do not double quote string in yaml config example (#1728) parse numerical abbreviations (#1719) [master] Make storage size configuration more explicit (#1721) License and reuse adaptions (#1718) Prepare next Development Cycle 1.74.0-dev Release 1.73.0 rm tonal variant from worker cards (#1715) Fix viewer handling for secret name (#1714) Support viewer to download `gardenlogin` kubeconfig by fetching cluster CA via `ConfigMap` (#1708) removed force delete feature flag from dashboard configuration (#1713)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
needs/ok-to-test
Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
reviewed/lgtm
Has approval for merging
size/m
Size of pull request is medium (see gardener-robot robot/bots/size.py)
status/closed
Issue is closed (either delivered or triaged)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Enhanced Volume Management for OpenStack Workers
This Fix addresses and resolves a critical issue our users have experienced. Previously, updating OpenStack workers via the dashboard inadvertently led to the loss of custom volume sizes. This release brings a fix to this bug, ensuring that your custom volume configurations are retained post-update.
Additionally, we've improved the storage size configuration interface. Now, it's easier to distinguish between default and custom volumes, allowing for a more intuitive setup process. This enhancement aims to streamline your experience, making volume management more straightforward and error-free.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Release note: