Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

parse numerical abbreviations #1719

Merged
merged 4 commits into from
Feb 26, 2024
Merged

parse numerical abbreviations #1719

merged 4 commits into from
Feb 26, 2024

Conversation

grolu
Copy link
Contributor

@grolu grolu commented Feb 16, 2024

What this PR does / why we need it:

Which issue(s) this PR fixes:
Fixes #1716

Special notes for your reviewer:

Release note:

Fixed an issue that caused quotas using numerical abbreviations (e.g., '1k') to not be displayed correctly in the Gardener Dashboard

@gardener-robot gardener-robot added needs/review Needs review size/s Size of pull request is small (see gardener-robot robot/bots/size.py) labels Feb 16, 2024
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Feb 16, 2024
@gardener-robot-ci-3 gardener-robot-ci-3 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Feb 16, 2024
@gardener-robot
Copy link

@holgerkoser You have pull request review open invite, please check

holgerkoser
holgerkoser reviewed Feb 22, 2024
View reviewed changes
@gardener-robot-ci-2 gardener-robot-ci-2 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Feb 23, 2024
holgerkoser
holgerkoser approved these changes Feb 23, 2024
View reviewed changes
Copy link
Member

@holgerkoser holgerkoser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
Eventuell noch die error message ohne regex

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Feb 23, 2024
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Feb 23, 2024
@gardener-robot-ci-3 gardener-robot-ci-3 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Feb 23, 2024
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Feb 23, 2024
@gardener-robot-ci-3 gardener-robot-ci-3 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Feb 23, 2024
petersutter
petersutter approved these changes Feb 26, 2024
View reviewed changes
Copy link
Member

@petersutter petersutter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@grolu grolu merged commit a5ac97c into master Feb 26, 2024
9 checks passed
@grolu grolu deleted the bug/fix_quota_numbers branch February 26, 2024 10:49
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Feb 26, 2024
holgerkoser added a commit that referenced this pull request Mar 7, 2024
@holgerkoser
Merge branch 'master' into enh/fix-1621
ba662f5 
* master:
  Do not double quote string in yaml config example (#1728)
  parse numerical abbreviations (#1719)
  [master] Make storage size configuration more explicit (#1721)
  License and reuse adaptions (#1718)
  Prepare next Development Cycle 1.74.0-dev
  Release 1.73.0
  rm tonal variant from worker cards (#1715)
  Fix viewer handling for secret name (#1714)
  Support viewer to download `gardenlogin` kubeconfig by fetching cluster CA via `ConfigMap` (#1708)
  removed force delete feature flag from dashboard configuration (#1713)
@grolu grolu added the area/ipcei IPCEI (Important Project of Common European Interest) label Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@holgerkoser holgerkoser holgerkoser approved these changes

@petersutter petersutter petersutter approved these changes

Assignees
No one assigned
Labels
area/ipcei IPCEI (Important Project of Common European Interest) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging size/s Size of pull request is small (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Dashboard cannot display quotas that are numerical abbreviations
7 participants
@grolu @gardener-robot @holgerkoser @petersutter @gardener-robot-ci-1 @gardener-robot-ci-2 @gardener-robot-ci-3