Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix mountPath of assets #1266

Merged
merged 1 commit into from
Jul 28, 2022
Merged

Fix mountPath of assets #1266

merged 1 commit into from
Jul 28, 2022

Conversation

holgerkoser
Copy link
Member

@holgerkoser holgerkoser commented Jul 28, 2022 •
edited by grolu
Loading

What this PR does / why we need it:
Update the mountPath of the assets volumeMount to match the workdir of the docker image.

Which issue(s) this PR fixes:
Fixes #1265 #1264

Special notes for your reviewer:

Release note:

Fixed the broken theming of logos and icons.

@gardener-robot gardener-robot added needs/review Needs review size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) labels Jul 28, 2022
@gardener-robot-ci-3 gardener-robot-ci-3 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jul 28, 2022
petersutter
petersutter approved these changes Jul 28, 2022
View reviewed changes
Copy link
Member

@petersutter petersutter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Jul 28, 2022
@holgerkoser holgerkoser merged commit 0cf2b06 into master Jul 28, 2022
@holgerkoser holgerkoser deleted the bug/fix-1265 branch July 28, 2022 13:14
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Jul 28, 2022
@holgerkoser holgerkoser mentioned this pull request Jul 28, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@petersutter petersutter petersutter approved these changes

@grolu grolu Awaiting requested review from grolu grolu is a code owner

Assignees
No one assigned
Labels
needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Theming of Logos and Icons is broken
4 participants
@holgerkoser @petersutter @gardener-robot-ci-3 @gardener-robot