Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trigger control plane migration #1262

Merged
merged 11 commits into from
Aug 15, 2022
Merged

Trigger control plane migration #1262

merged 11 commits into from
Aug 15, 2022

Conversation

grolu
Copy link
Contributor

@grolu grolu commented Jul 26, 2022

What this PR does / why we need it:
This PR adds the ability to trigger control plane migration from the gardener dashboard.
The dialog is only visible to users that have permission to patch the shoots/binding subresource.

Screen Shot 2022-07-26 at 14 42 51

Screen Shot 2022-07-26 at 14 43 02

Which issue(s) this PR fixes:
Fixes #1256

Special notes for your reviewer:

Release note:

Operators can now trigger control plane migration via a configuration dialog. The configuration button is hidden for regular users, unless they have been granted permission to trigger a control plane migration for their shoots

@gardener-robot gardener-robot added needs/review Needs review size/l Size of pull request is large (see gardener-robot robot/bots/size.py) needs/second-opinion Needs second review by someone else labels Jul 26, 2022
@gardener-robot-ci-1 gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jul 26, 2022
@grolu grolu force-pushed the enh/trigger_cp_migration branch from 7d066ea to a86e033 Compare July 26, 2022 13:17
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jul 26, 2022
@grolu
Copy link
Contributor Author

grolu commented Jul 26, 2022

@plkokanov @RaphaelVogel

@gardener-robot-ci-2 gardener-robot-ci-2 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jul 26, 2022
@grolu grolu force-pushed the enh/trigger_cp_migration branch from a86e033 to 762e6af Compare July 26, 2022 13:23
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jul 26, 2022
@gardener-robot-ci-1 gardener-robot-ci-1 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jul 26, 2022
@plkokanov
Copy link

Thanks a lot!
Just a few questions:

  • It looks like the seed cluster selection is a drop down dialogue. Does it list all seeds on the garden landscape or only those that match the shoot's provider? I guess users will also require permissions to list seeds.
  • Should we rename the name of the dialogue to Change Seed instead of Configure Seed? At least to me it seems a bit more appropriate.

@grolu
Copy link
Contributor Author

grolu commented Jul 27, 2022

It looks like the seed cluster selection is a drop down dialogue. Does it list all seeds on the garden landscape or only those that match the shoot's provider? I guess users will also require permissions to list seeds.

Yes, we currently do not filter by provider. We can add that.
I tested with a service account, I was able to list the seed using the service account and only needed to add a role to patch the /binding subresource

Should we rename the name of the dialogue to Change Seed instead of Configure Seed? At least to me it seems a bit more appropriate.

We can rename it I labelled it that way because we have it like that for all the Configure Dialogs, e.g. purpose is also called Configure Purpose so I guess we should change it for hat one, too?

@gardener-robot gardener-robot added size/m Size of pull request is medium (see gardener-robot robot/bots/size.py) and removed size/l Size of pull request is large (see gardener-robot robot/bots/size.py) labels Aug 5, 2022
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Aug 5, 2022
@gardener-robot-ci-1 gardener-robot-ci-1 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Aug 5, 2022
@gardener-robot-ci-1 gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Aug 10, 2022
@gardener-robot-ci-2 gardener-robot-ci-2 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Aug 10, 2022
Copy link
Member

@petersutter petersutter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review needs/second-opinion Needs second review by someone else labels Aug 12, 2022
@gardener-robot gardener-robot added size/l Size of pull request is large (see gardener-robot robot/bots/size.py) needs/second-opinion Needs second review by someone else and removed size/m Size of pull request is medium (see gardener-robot robot/bots/size.py) reviewed/lgtm Has approval for merging labels Aug 15, 2022
@gardener-robot-ci-3 gardener-robot-ci-3 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Aug 15, 2022
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Aug 15, 2022
@gardener-robot-ci-2 gardener-robot-ci-2 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Aug 15, 2022
@grolu grolu merged commit b021789 into master Aug 15, 2022
@grolu grolu deleted the enh/trigger_cp_migration branch August 15, 2022 15:34
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Aug 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/second-opinion Needs second review by someone else size/l Size of pull request is large (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add ability to trigger control plane migration from the gardener dashboard
8 participants