Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the Azure secret dialog #1255

Merged
merged 1 commit into from
Jul 18, 2022
Merged

Update the Azure secret dialog #1255

merged 1 commit into from
Jul 18, 2022

Conversation

dkistner
Copy link
Member

What this PR does / why we need it:
Update the Azure secret dialog with a hint to use fine-grained permissions instead of simply the Contributor role.

Special notes for your reviewer:
Depend on gardener/gardener-extension-provider-azure#536 (until this merged → draft)

Release note:

The Azure secret dialog hints now to use more fine-grained Azure permissions for Shoots on Azure.

@gardener-robot gardener-robot added needs/review Needs review size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) labels Jul 14, 2022
@gardener-robot-ci-3 gardener-robot-ci-3 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jul 14, 2022
@dkistner
Copy link
Member Author

https://github.com/gardener/gardener-extension-provider-azure/blob/master/docs/azure-permissions.md is now available.

/ready-for-review

@gardener-robot gardener-robot marked this pull request as ready for review July 14, 2022 13:26
petersutter
petersutter approved these changes Jul 14, 2022
View reviewed changes
Copy link
Member

@petersutter petersutter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Jul 14, 2022
holgerkoser
holgerkoser approved these changes Jul 15, 2022
View reviewed changes
Copy link
Member

@holgerkoser holgerkoser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@dkistner @petersutter
Update the Azure secret dialog
52438cb 
with a hint to use fine-grained permissions instead of simply the Contributer role.
@gardener-robot-ci-2 gardener-robot-ci-2 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jul 18, 2022
@petersutter petersutter merged commit 31edd75 into gardener:master Jul 18, 2022
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Jul 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@petersutter petersutter petersutter approved these changes

@holgerkoser holgerkoser holgerkoser approved these changes

@grolu grolu Awaiting requested review from grolu grolu is a code owner

Assignees
No one assigned
Labels
needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@dkistner @holgerkoser @petersutter @gardener-robot-ci-2 @gardener-robot-ci-3 @gardener-robot