Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implemented Disable Gardener provided static admin kubeconfig #1249

Merged
merged 10 commits into from
Aug 16, 2022
Merged

Implemented Disable Gardener provided static admin kubeconfig #1249

merged 10 commits into from
Aug 16, 2022

Conversation

grolu
Copy link
Contributor

@grolu grolu commented Jul 4, 2022 •
edited
Loading

What this PR does / why we need it:
Support to disable admin kubeconfig during cluster creation and on shoot details page

Screen Shot 2022-08-16 at 14 00 01

Screen Shot 2022-08-16 at 14 00 15

Screen Shot 2022-07-06 at 14 30 58

Which issue(s) this PR fixes:
Fixes #1186

Special notes for your reviewer:

Release note:

Static token kubeconfig cluster access can be disabled for new and existing clusters

@gardener-robot gardener-robot added needs/review Needs review size/l Size of pull request is large (see gardener-robot robot/bots/size.py) needs/second-opinion Needs second review by someone else labels Jul 4, 2022
@gardener-robot-ci-3 gardener-robot-ci-3 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jul 4, 2022
@rfranzke
Copy link
Member

rfranzke commented Jul 4, 2022

Add a link to https://github.com/gardener/gardener/blob/master/docs/usage/shoot_access.md

@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jul 6, 2022
@gardener-robot-ci-1 gardener-robot-ci-1 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jul 6, 2022
@gardener-robot
Copy link

@holgerkoser You have pull request review open invite, please check

@gardener-robot-ci-3 gardener-robot-ci-3 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jul 13, 2022
@gardener-robot-ci-1 gardener-robot-ci-1 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jul 13, 2022
@grolu grolu force-pushed the enh/disable_admin_kubeconfig branch from 14780c0 to 4147460 Compare July 13, 2022 09:12
holgerkoser
holgerkoser reviewed Jul 28, 2022
View reviewed changes
frontend/src/components/ShootDetails/ShootAccessCard.vue Outdated Show resolved Hide resolved
frontend/src/components/StaticTokenKubeconfigConfiguration.vue Outdated Show resolved Hide resolved
frontend/src/components/StaticTokenKubeconfigConfiguration.vue Show resolved Hide resolved
frontend/src/components/StaticTokenKubeconfigSwitch.vue Outdated Show resolved Hide resolved
frontend/src/components/StaticTokenKubeconfigConfiguration.vue Outdated Show resolved Hide resolved
frontend/src/components/StaticTokenKubeconfigConfiguration.vue Outdated Show resolved Hide resolved
frontend/src/components/StaticTokenKubeconfigConfiguration.vue Outdated Show resolved Hide resolved
frontend/src/views/NewShoot.vue Outdated Show resolved Hide resolved
frontend/src/views/NewShoot.vue Outdated Show resolved Hide resolved
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Aug 10, 2022
@gardener-robot-ci-2 gardener-robot-ci-2 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Aug 10, 2022
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Aug 10, 2022
@gardener-robot-ci-2 gardener-robot-ci-2 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Aug 10, 2022
@gardener-robot-ci-3 gardener-robot-ci-3 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Aug 16, 2022
@grolu grolu force-pushed the enh/disable_admin_kubeconfig branch from 9d9331d to 1436b52 Compare August 16, 2022 10:23
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Aug 16, 2022
@gardener-robot-ci-2 gardener-robot-ci-2 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Aug 16, 2022
@gardener-robot gardener-robot added size/m Size of pull request is medium (see gardener-robot robot/bots/size.py) and removed size/l Size of pull request is large (see gardener-robot robot/bots/size.py) labels Aug 16, 2022
@gardener-robot-ci-2 gardener-robot-ci-2 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Aug 16, 2022
@gardener-robot-ci-2 gardener-robot-ci-2 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Aug 16, 2022
@petersutter petersutter self-requested a review August 16, 2022 11:32
petersutter
petersutter approved these changes Aug 16, 2022
View reviewed changes
Copy link
Member

@petersutter petersutter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review needs/second-opinion Needs second review by someone else labels Aug 16, 2022
@grolu grolu merged commit 96ca659 into master Aug 16, 2022
@grolu grolu deleted the enh/disable_admin_kubeconfig branch August 16, 2022 12:01
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Aug 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@holgerkoser holgerkoser holgerkoser left review comments

@petersutter petersutter petersutter approved these changes

Assignees
No one assigned
Labels
needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging size/m Size of pull request is medium (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow the user to disable/enable the admin kubeconfig
8 participants
@grolu @rfranzke @gardener-robot @holgerkoser @petersutter @gardener-robot-ci-1 @gardener-robot-ci-2 @gardener-robot-ci-3