From 960c1be98ea1708b990178e1d05aa43a07fbeaaf Mon Sep 17 00:00:00 2001
From: Peter Sutter <peter.sutter@sap.com>
Date: Wed, 26 Jun 2024 18:55:13 +0200
Subject: [PATCH] Apply suggestions from code review

Co-authored-by: Lukas Gross <lukas.gross@sap.com>
---
 frontend/src/components/GShootListRow.vue                | 9 ++-------
 .../src/components/ShootDetails/GCustomFieldsCard.vue    | 8 ++------
 2 files changed, 4 insertions(+), 13 deletions(-)

diff --git a/frontend/src/components/GShootListRow.vue b/frontend/src/components/GShootListRow.vue
index a727bc16ec..8c0168622a 100644
--- a/frontend/src/components/GShootListRow.vue
+++ b/frontend/src/components/GShootListRow.vue
@@ -151,14 +151,14 @@ SPDX-License-Identifier: Apache-2.0
           <template #activator="slotProps">
             <span
               v-bind="slotProps.props"
-              :class="classForValue(cell.value)"
+              :class="{'text-disabled' : !cell.value}"
             >{{ cell.displayValue }}</span>
           </template>
           {{ cell.header.tooltip }}
         </v-tooltip>
         <span
           v-else-if="cell.displayValue"
-          :class="classForValue(cell.value)"
+         :class="{'text-disabled' : !cell.value}"
         >
           {{ cell.displayValue }}
         </span>
@@ -399,11 +399,6 @@ function showDialog (action) {
   })
 }
 
-function classForValue (value) {
-  return {
-    'text-grey': !value,
-  }
-}
 </script>
 
 <style lang="scss" scoped>
diff --git a/frontend/src/components/ShootDetails/GCustomFieldsCard.vue b/frontend/src/components/ShootDetails/GCustomFieldsCard.vue
index fbcfb6d2ba..09656af1b7 100644
--- a/frontend/src/components/ShootDetails/GCustomFieldsCard.vue
+++ b/frontend/src/components/ShootDetails/GCustomFieldsCard.vue
@@ -37,14 +37,14 @@ SPDX-License-Identifier: Apache-2.0
               <template #activator="{ props }">
                 <span
                   v-bind="props"
-                  :class="classForValue(field.value)"
+                  :class="{'text-disabled' : !field.value}"
                 >{{ field.displayValue }}</span>
               </template>
               {{ field.tooltip }}
             </v-tooltip>
             <span
               v-else-if="field.displayValue"
-              :class="classForValue(field.value)"
+             :class="{'text-disabled' : !field.value}"
             >
               {{ field.displayValue }}
             </span>
@@ -97,9 +97,5 @@ const customFieldValues = computed(() => {
   })
 })
 
-function classForValue (value) {
-  return {
-    'text-grey': !value,
-  }
 }
 </script>