Apply suggestions from code review

Co-authored-by: Lukas Gross <[email protected]>
gardener · Jun 26, 2024 · 960c1be · 960c1be
1 parent 49a81e5
commit 960c1be
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 13 deletions.
diff --git a/frontend/src/components/GShootListRow.vue b/frontend/src/components/GShootListRow.vue
@@ -151,14 +151,14 @@ SPDX-License-Identifier: Apache-2.0
           <template #activator="slotProps">
             <span
               v-bind="slotProps.props"
-              :class="classForValue(cell.value)"
+              :class="{'text-disabled' : !cell.value}"
             >{{ cell.displayValue }}</span>
           </template>
           {{ cell.header.tooltip }}
         </v-tooltip>
         <span
           v-else-if="cell.displayValue"
-          :class="classForValue(cell.value)"
+         :class="{'text-disabled' : !cell.value}"
         >
           {{ cell.displayValue }}
         </span>
@@ -399,11 +399,6 @@ function showDialog (action) {
   })
 }
 
-function classForValue (value) {
-  return {
-    'text-grey': !value,
-  }
-}
 </script>
 
 <style lang="scss" scoped>

diff --git a/frontend/src/components/ShootDetails/GCustomFieldsCard.vue b/frontend/src/components/ShootDetails/GCustomFieldsCard.vue
@@ -37,14 +37,14 @@ SPDX-License-Identifier: Apache-2.0
               <template #activator="{ props }">
                 <span
                   v-bind="props"
-                  :class="classForValue(field.value)"
+                  :class="{'text-disabled' : !field.value}"
                 >{{ field.displayValue }}</span>
               </template>
               {{ field.tooltip }}
             </v-tooltip>
             <span
               v-else-if="field.displayValue"
-              :class="classForValue(field.value)"
+             :class="{'text-disabled' : !field.value}"
             >
               {{ field.displayValue }}
             </span>
@@ -97,9 +97,5 @@ const customFieldValues = computed(() => {
   })
 })
 
-function classForValue (value) {
-  return {
-    'text-grey': !value,
-  }
 }
 </script>