Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GetOptions implementation of NodeGroup interface does not return the default values for some options #308

Closed
rishabh-11 opened this issue Jul 4, 2024 · 0 comments · Fixed by #310
Assignees
Labels
kind/bug Bug status/closed Issue is closed (either delivered or triaged)

Comments

@rishabh-11
Copy link

What happened:
GetOptions implementation of NodeGroup interface does not return the default values for some options. The reason for this is in the code

func (machinedeployment *MachineDeployment) GetOptions(defaults config.NodeGroupAutoscalingOptions) (*config.NodeGroupAutoscalingOptions, error) {
, we do not set the default values for these options even though they are configured via the CA flags.

What you expected to happen:
GetOptions should return the correct values for all the options (along with proper defaults).

How to reproduce it (as minimally and precisely as possible):
Live issue 5129

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Bug status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants