From 52392b3707cb8192bd2841b6f2e8da9678c13fd9 Mon Sep 17 00:00:00 2001 From: Maciek Pytel Date: Thu, 8 Jul 2021 15:14:26 +0200 Subject: [PATCH] Skipping metrics tests added in #4022 Each test works in isolation, but they cause panic when the entire suite is run (ex. make test-in-docker), because the underlying metrics library panics when the same metric is registered twice. --- cluster-autoscaler/metrics/metrics_test.go | 2 ++ 1 file changed, 2 insertions(+) diff --git a/cluster-autoscaler/metrics/metrics_test.go b/cluster-autoscaler/metrics/metrics_test.go index 71789d2c7a48..4bbe87b526f6 100644 --- a/cluster-autoscaler/metrics/metrics_test.go +++ b/cluster-autoscaler/metrics/metrics_test.go @@ -24,12 +24,14 @@ import ( ) func TestDisabledPerNodeGroupMetrics(t *testing.T) { + t.Skip("Registering metrics multiple times causes panic. Skipping until the test is fixed to not impact other tests.") RegisterAll(false) assert.False(t, nodesGroupMinNodes.IsCreated()) assert.False(t, nodesGroupMaxNodes.IsCreated()) } func TestEnabledPerNodeGroupMetrics(t *testing.T) { + t.Skip("Registering metrics multiple times causes panic. Skipping until the test is fixed to not impact other tests.") RegisterAll(true) assert.True(t, nodesGroupMinNodes.IsCreated()) assert.True(t, nodesGroupMaxNodes.IsCreated())