feat: allow overriding source.path in remote actions (when using source.repository)
#6750
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stefreak
force-pushed
the
feat-remote-action-path
branch
2 times, most recently
from
ca72612 to
a6bcbec
Compare
twelvemo
requested changes
Jan 8, 2025
| @@ -44,11 +44,9 @@ A description of the action. | |||
|
|
|||
| By default, the directory where the action is defined is used as the source for the build context. | |||
|
|
|||
| You can override this by setting either `source.path` to another (POSIX-style) path relative to the action source directory, or `source.repository` to get the source from an external repository. | |||
| You can override directory that is used for the build context by setting `source.path`. | |||
There was a problem hiding this comment.
Suggested change
| You can override directory that is used for the build context by setting `source.path`. | |
| You can override the directory that is used for the build context by setting `source.path`. |
There was a problem hiding this comment.
Thank you for spotting this, I have applied your suggestion ✅
…ource.repository`)
stefreak
force-pushed
the
feat-remote-action-path
branch
from
a6bcbec to
dbb75e2
Compare
twelvemo
approved these changes
Jan 8, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Allow overriding
source.pathin remote actions (when usingsource.repository).This is useful when an action source path needs to be a subdirectory in a remote repository.
Special notes for your reviewer:
This feature already was working, I just lifted the limitation in the validation code and added a test, and updated docs.
See also Discord thread: https://discord.com/channels/817392104711651328/1320775997880144005/1320775997880144005