Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(k8s-exec): use containerName if specified for kubernetes-exec actions #6682

Merged
merged 1 commit into from
Nov 26, 2024

Conversation

twelvemo
Copy link
Collaborator

@twelvemo twelvemo commented Nov 26, 2024

What this PR does / why we need it:
In the kubernetes-exec actions we were not passing on the action.spec.resource.containerName resulting in always the first container to be picked e.g. for test actions.
Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

@twelvemo twelvemo requested a review from 10ko November 26, 2024 14:49
@twelvemo twelvemo enabled auto-merge November 26, 2024 14:50
@twelvemo twelvemo added this pull request to the merge queue Nov 26, 2024
Merged via the queue into main with commit 976ab70 Nov 26, 2024
40 checks passed
@twelvemo twelvemo deleted the use-containername branch November 26, 2024 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants