Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(exec): separate stdout and stderr in Run and Test exec-action outputs #6572

Merged
merged 3 commits into from
Oct 22, 2024

Conversation

vvagaytsev
Copy link
Collaborator

@vvagaytsev vvagaytsev commented Oct 22, 2024

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #6556

Special notes for your reviewer:

@vvagaytsev vvagaytsev changed the title feat(exec): separate stdout and stderr in exec-action outputs feat(exec): separate stdout and stderr in Run and Test exec-action outputs Oct 22, 2024
@vvagaytsev vvagaytsev force-pushed the feat/separate-run-and-test-action-stdio branch from 236ced0 to 5ed9801 Compare October 22, 2024 05:46
@vvagaytsev vvagaytsev force-pushed the feat/separate-run-and-test-action-stdio branch from 5ed9801 to 5556b2f Compare October 22, 2024 06:03
@vvagaytsev vvagaytsev requested review from thsig and eysi09 October 22, 2024 07:48
@vvagaytsev vvagaytsev marked this pull request as ready for review October 22, 2024 07:48
@vvagaytsev
Copy link
Collaborator Author

@eysi09 @thsig this addresses the feature request from #6556.

I've implemented that only for Run and Test action kinds of exec action type. That was quite simple do to.

Should we do the same for container, kubernetes and helm action types? That requires broader changes across the code base and the log retrieval utilities.

@thsig
Copy link
Collaborator

thsig commented Oct 22, 2024

Should we do the same for container, kubernetes and helm action types? That requires broader changes across the code base and the log retrieval utilities.

It would definitely make sense to have that too, but maybe we should wait for a user or two to ask for it before starting work on it.

@thsig thsig added this pull request to the merge queue Oct 22, 2024
Merged via the queue into main with commit 5a04f60 Oct 22, 2024
42 checks passed
@thsig thsig deleted the feat/separate-run-and-test-action-stdio branch October 22, 2024 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE]: Provide separate action output for stdout and stderr
2 participants