fix(pulumi): stack not being selected before getting outputs when autoApply = false #6554
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
When you set
autoApplytofalsein a Pulumi deploy action, the correct stack hasn't been selected yet, so it'll pull outputs from whichever stack was last selected.Special notes for your reviewer:
I don't know whether or not it's worth the effort right now, but I think it might be less error prone if you were able to set the stack with
--stackon every pulumi command by having that set at theCliWrapperlevel somehow. This would also avoid the overhead of spinning up a pulumi process to change stacks.