feat(k8s): allow using registry mirror for utility images #6552
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eysi09
force-pushed
the
allow-registry-mirror
branch
9 times, most recently
from
c452a78 to
05e717d
Compare
eysi09
changed the title
eysi09
force-pushed
the
allow-registry-mirror
branch
from
05e717d to
c146062
Compare
Garden uses various utility container images, e.g. for the K8s sync utility pod, and hosts them on Docker Hub. Some users have their own mirror of Docker Hub that they'd rather use instead of Docker Hub itself. This avoids issues with rate limiting among other things. This commit adds a config field on the Kubernetes provider spec that allows users to configure what registry is used. Note that it only allows users to specify the registry domain, not the repository, image name, or tag. So the assumption is that mirror has the exact same "layout" as Docker Hub itself which is usually (always?) the case. If needed, we can later expose more granular control, e.g. setting the image tag, but that's not required for now.
eysi09
force-pushed
the
allow-registry-mirror
branch
from
da03f3c to
42178fe
Compare
twelvemo
approved these changes
Oct 18, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Garden uses various utility container images, e.g. for the K8s sync utility pod, and hosts them on Docker Hub.
Some users have their own mirror of Docker Hub that they'd rather use instead of Docker Hub itself. This avoids issues with rate limiting among other things.
This commit adds a config field on the Kubernetes provider spec that allows users to configure what registry is used.
Note that it only allows users to specify the registry domain, not the repository, image name, or tag. So the assumption is that mirror has the exact same "layout" as Docker Hub itself which is usually (always?) the case.
If needed, we can later expose more granular control, e.g. setting the image tag, but that's not required for now.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer: