fix(pulumi): prevent existing pulumi configs from being overwritten #6526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BraedonLeonard
commented
Oct 8, 2024
vvagaytsev
approved these changes
Oct 10, 2024
vvagaytsev
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR addresses an issue where existing pulumi config files fail to be read in, and are then overwritten by Garden, essentially deleting all existing config from the file.
Special notes for your reviewer:
In
applyConfig(), there's this line here that overwrites the pulumi config that gets read in:The docs for the pulumi provider and actions aren't clear about how existing pulumi config files are handled, so I'm not sure if this is intentional or not, but I'm pretty sure this is meant to merge these values into the existing pulumi config, rather than overwriting it. Since I wasn't certain about whether or not this was intentional, I left it alone and just called it out here.